[CLOSED] Restore the QuickOpen.basicMatchSort and friends

[core-ai-bot]

Issue by dangoor
Thursday Oct 30, 2014 at 15:36 GMT
Originally opened as adobe/brackets#9747

---

This change broke a few extensions. Looking at the fix, it seems that all QuickOpen plugins will
likely need these functions, so we may as well re-export them as we have been doing rather than
requiring the extensions to all add another import.

If we do decide to deprecate these later, we should do so with deprecation warnings (something we
weren't doing when these were moved to the StringMatch module).

Revert "Marked as deprecated by adobe/brackets#2462 in Sprint 19"

This reverts commit 49e08274a0bc9259d6dd94c03351e4c87bf570f9.

---

dangoor included the following code: https://github.com/adobe/brackets/pull/9747/commits

[core-ai-bot]

Comment by JeffryBooher
Thursday Oct 30, 2014 at 16:22 GMT

---

LGTM

[core-ai-bot]

Comment by le717
Thursday Oct 30, 2014 at 17:07 GMT

---

Sorry about this guys. :(

[core-ai-bot]

Comment by dangoor
Thursday Oct 30, 2014 at 17:17 GMT

---

@le717 No problem. I can certainly see how something that appeared to be deprecated since sprint 19 should be safe to remove.

[core-ai-bot]

Comment by le717
Thursday Oct 30, 2014 at 17:21 GMT

---

@dangoor Would you like me to submit a PR marking these using DeprecationWarning for 1.1 or do they just need to be noted in a card for eventual removal?

[core-ai-bot]

Comment by dangoor
Thursday Oct 30, 2014 at 17:25 GMT

---

@le717 No, I actually considered leaving these removed and decided to put them back because it made the extension code a bit uglier. So, I updated the comment to reflect that I think these should stay.

[core-ai-bot]

Comment by le717
Thursday Oct 30, 2014 at 17:28 GMT

---

Yea, that makes sense. However, since they are convenience exports, it probably should be noted somewhere there is a chance they might break later on (just as a general statement, not necessarily going to happen).

[core-ai-bot]

Comment by dangoor
Thursday Oct 30, 2014 at 17:53 GMT

---

You could almost say that about any of our APIs... there's always a chance they can break later on. As much as possible, though, when we do decide to break them, we will try to put deprecation warnings on first.