-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Close others extension improvements #5952
Close others extension improvements #5952
Conversation
Nominating for Sprint 35 |
Hi @sathyamoorthi -- since we have shorter sprints due to the holidays, it looks like we won't get to this until early 2014. Thanks for your hard work on this effort! |
@JeffryBooher sure. np. |
@JeffryBooher Is this PR still required, since #6020 kind of does the same and was merged recently? |
@TomMalbran I guess that depends on which direction @larz0 wants to go. pr #6020 grays the menu items that do not work for that particular context (which I prefer) while this pr removes the menu items from the context menu. This doesn't obviate #6020, however, since that pr laid the plumbing to gray out menu items. |
Graying out items that don't work is much better because it won't mess with the user's spatial or muscle memory i.e. the items are always at the same spot in the menu no matter what. |
@sathyamoorthi This PR is obsolete now that the other one has been merged, right? Should we close this? |
@peterflynn yep. sure. |
Code added to dynamically add and remove context menus (Close others / above / below) based working set file selection.