Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Close others extension improvements #5952

Closed
wants to merge 4 commits into from
Closed

Close others extension improvements #5952

wants to merge 4 commits into from

Conversation

sathyamoorthi
Copy link
Contributor

Code added to dynamically add and remove context menus (Close others / above / below) based working set file selection.

@ghost ghost assigned ingorichter Nov 12, 2013
@JeffryBooher
Copy link
Contributor

Nominating for Sprint 35

@JeffryBooher
Copy link
Contributor

Hi @sathyamoorthi -- since we have shorter sprints due to the holidays, it looks like we won't get to this until early 2014. Thanks for your hard work on this effort!

@sathyamoorthi
Copy link
Contributor Author

@JeffryBooher sure. np.

@TomMalbran
Copy link
Contributor

@JeffryBooher Is this PR still required, since #6020 kind of does the same and was merged recently?

@JeffryBooher
Copy link
Contributor

@TomMalbran I guess that depends on which direction @larz0 wants to go. pr #6020 grays the menu items that do not work for that particular context (which I prefer) while this pr removes the menu items from the context menu.

This doesn't obviate #6020, however, since that pr laid the plumbing to gray out menu items.

@larz0
Copy link
Member

larz0 commented Mar 10, 2014

Graying out items that don't work is much better because it won't mess with the user's spatial or muscle memory i.e. the items are always at the same spot in the menu no matter what.

@peterflynn
Copy link
Member

@sathyamoorthi This PR is obsolete now that the other one has been merged, right? Should we close this?

@sathyamoorthi
Copy link
Contributor Author

@peterflynn yep. sure.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants