Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Fix for issue #5800 #5866

Closed
wants to merge 4 commits into from
Closed

Fix for issue #5800 #5866

wants to merge 4 commits into from

Conversation

sathyamoorthi
Copy link
Contributor

@JeffryBooher Fix for issue #5800 introduced by #4590

@ingorichter
Copy link
Contributor

@sathyamoorthi Would you mind resolving the merge issue? I'd like to get this PR into master. Thank you.

@sathyamoorthi
Copy link
Contributor Author

@ingorichter Shall i include other changes that this #5497 contains. They merged new file system into brackets. So we don't have issues to add other improvements that i gave in this PR (#5497)

@sathyamoorthi
Copy link
Contributor Author

@ingorichter I think, i should have fixed your merge issues. Please take a look.

@ingorichter
Copy link
Contributor

@sathyamoorthi wow, I think this looks like a lot of changes. I would recommend to check out a clean copy of the repo and apply your changes there and submit a new PR. I don't know how to fix the current PR to only contain the changes that you've made. Sorry for telling you that.

@njx
Copy link

njx commented Nov 12, 2013

This PR looks clean to me--only 3 line diffs and 4 commits (of which two were merge commits). Maybe GitHub got briefly confused?

@sathyamoorthi
Copy link
Contributor Author

Ok let me give new PR. But, shall i include my other changes in this PR (close other improvements) to my new PR?

@sathyamoorthi
Copy link
Contributor Author

@ingorichter I created two new pull requests.

#5951 - only few lines of changes to fix issue 5800.

#5952 - it has fix for issue 5800 along with some improvements. They were discussed already in this PR #5497.

But please pull any one of this before sprint 34. If you pull 5951, let 5952 open and assign it to @JeffryBooher. And i really don't know why my 'upstream/master' merge commits are stick along with these pull requests.

I only ran these two commands based on this document.

git fetch upstream
git fetch upstream/master

If you still feel anything weird, please do let me know. I can delete my entire fork and create new fork for this PR.

@ingorichter
Copy link
Contributor

@njx weird. The page to show all the diffs was hardly rendered.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants