Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Dutch Translation #5372

Merged
merged 7 commits into from
Nov 9, 2013
Merged

Dutch Translation #5372

merged 7 commits into from
Nov 9, 2013

Conversation

Wanimatrix
Copy link
Contributor

With this pull request a Dutch translation is added to the Brackets application.
Also in the root strings.js the name for this language is added and translated in the dutch strings.js

@WebsiteDeveloper
Copy link
Contributor

@Wouter92 you should find someone to do a peer review of your translation.

@Wanimatrix
Copy link
Contributor Author

@WebsiteDeveloper Does the reviewer need to have a GitHub account or can I let this be reviewed offline?

@WebsiteDeveloper
Copy link
Contributor

@Wouter92 i think it would be best if he had one to review it in this pull request.

@couzteau
Copy link
Member

couzteau commented Nov 8, 2013

I'll go ahead and merge this based on verification using automatic translation. @Wouter92 Could you merge master again?

@Wanimatrix
Copy link
Contributor Author

What do you mean? There is nothing changed from my master since then if that's what you mean.

@couzteau
Copy link
Member

couzteau commented Nov 8, 2013

src/nls/root/strings.js
src/nls/de/strings.js
src/nls/strings.js

These have changed in brackets master. Github disables merge per browser in these situations. If you could merge the latest brackets master into your branch that would help. You may also look if there have been string changes in english since you submitted your request that you'd want to incorporate into your translation.

Wouter Franken added 2 commits November 8, 2013 23:42
@Wanimatrix
Copy link
Contributor Author

I merged everything but I will add those changes in those files later on, because I've not much time to do this right now.

@couzteau
Copy link
Member

couzteau commented Nov 9, 2013

Dank u @Wouter92 - merging

couzteau added a commit that referenced this pull request Nov 9, 2013
@couzteau couzteau merged commit 5b550ee into adobe:master Nov 9, 2013
@marcelgerber
Copy link
Contributor

@couzteau As far as I can see we changed some submodule commit refs that shouldn't be changed.

@couzteau
Copy link
Member

couzteau commented Nov 9, 2013

Yes, that was an accident. but it's fixed already with 6ca6512

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants