-
Notifications
You must be signed in to change notification settings - Fork 18
Conversation
}, | ||
{ | ||
"name": "New CSS Rule", | ||
"description": "Quick Edit for CSS (Ctrl+E/⌘E) now has a New Rule button that creates a rule for the currently selected tag/class/id. You can modify the selector after it's created. You can also bring up Quick Edit on a tag/class/id that has no existing rules so that you can create a new rule." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Escape ⌘ to \u2318
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe shorten to something like...?
Quick Edit for CSS (Ctrl+E/⌘E) now has a New Rule button that creates a rule for the currently selected tag/class/id, even when no other rules exist. You can modify the selector after it's created.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. I noticed that we also have the Cmd symbol in the older update notification--should I fix it there too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, doesn't hurt.
@njx review complete. |
I guess we're assuming neither of the new locales will land in time? (adobe/brackets#5378 or adobe/brackets#5372) |
It doesn't sound like we had anyone stepping forward to review them yet (and it's been a few weeks). We can ping @couzteau to find out if he can look in the history to see who's reviewed them in the past. But I'd guess they won't land. |
}, | ||
{ | ||
"name": "Regular Expression Substitution", | ||
"description": "When doing a regular expression find/replace, you can use $1, $2, etc. in the replace string to refer to parenthesized subexpressions in the query string." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit: When using a regular expression in Find/Replace...
Updated, ready for re-review. |
Thanks! Re-review done. Merging. |
}, | ||
{ | ||
"name": "New CSS Rule from Quick Edit", | ||
"description": "Use the New Rule button in CSS Quick Edit (Ctrl+E/\u2318E) to create a rule for the currently selected tag/class/id, even if there aren't any existing rules. You can modify the selector after it's created." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was originally thinking we should emphasize that you can now use Quick Edit even when there are no rules, because previously it would do nothing. But maybe this is clear enough.
No description provided.