Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Updated the pt-Br translation #5349

Closed
wants to merge 1 commit into from

Conversation

danilo-valente
Copy link

Added new entries and translations.
Also removed entries that aren't used in Sprint 31

Added new entries and translations
@ghost ghost assigned TomMalbran Sep 26, 2013
@kkarlesk
Copy link
Contributor

@TomMalbran, are you able to do this?

@TomMalbran
Copy link
Contributor

No, I don't know Portuguese. Just Spanish and English.

@danilo-valente
Copy link
Author

Is there anybody who speaks Portuguese and could review this request?

@diegoleme
Copy link
Contributor

I'm Brazilian, this is my native language, I can help?

@njx
Copy link

njx commented Sep 30, 2013

@diegoleme - That would be great. If you could take a look at the changed items in this pull request (from the "Files Changed" tab above), and compare them against the associated strings in the English version (https://github.com/adobe/brackets/blob/master/src/nls/root/strings.js), that would be great. Add any comments inline in the "Files Changed" tab.

@ghost ghost assigned njx and TomMalbran Sep 30, 2013
@njx
Copy link

njx commented Sep 30, 2013

Unassigning for now so we can reassign. (But @TomMalbran, if you have time and could help shepherd this through that would be great. For languages we don't speak, we usually just take a look at the feedback from the language reviewer and make sure it gets properly incorporated by the original filer, and then double-check to make sure functionality isn't broken by embedded tags getting messed up, etc.)

@njx
Copy link

njx commented Sep 30, 2013

Oops, it looks like we now have two Portuguese pull requests (this one and #5146) - that last one got stuck in review (and it looks like @MarkLinus wasn't aware of it). @MarkLinus and @rodrigost23 - would one of you like to work on consolidating the two (or perhaps one of you could review the other's work)?

@diegoleme - let's wait until we hear from the filers before moving forward.

@danilo-valente
Copy link
Author

@njx Sure, I'll review his pull request

@njx
Copy link

njx commented Oct 2, 2013

Thanks @MarkLinus!

@ghost ghost assigned couzteau Oct 2, 2013
@couzteau
Copy link
Member

@MarkLinus Hello Mark, were you able to review?

@danilo-valente
Copy link
Author

Hi, @couzteau. Yeah, unfortunatelly, I got busy with my school exams, but I think that as of next monday I'll have time to do it. However, I have already checked the first 100 lines and there wasn't any mistranslations, just a few words that I'd translate differently.

@couzteau
Copy link
Member

Thank you @MarkLinus. Much appreciated

@danilo-valente
Copy link
Author

@couzteau Done! I've reviewed the translation suggested by @rodrigost23 in [https://github.com//pull/5146]

@couzteau
Copy link
Member

Thanks @MarkLinus, @rodrigost23 I'll be happy to merge once the pull has been updated.

@danilo-valente
Copy link
Author

Since this request is a duplicate of [https://github.com//issues/5146], which is now reviewed, I'm closing it.

@couzteau
Copy link
Member

couzteau commented Nov 1, 2013

@MarkLinus In order to update other people's pull requests you'll need commiter permissions on the other rperson's repo. Usually that's not the case in the common open source workflow. However I think you did the right thing, that is, consolidate the pull requests.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants