-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Conversation
Added new entries and translations
@TomMalbran, are you able to do this? |
No, I don't know Portuguese. Just Spanish and English. |
Is there anybody who speaks Portuguese and could review this request? |
I'm Brazilian, this is my native language, I can help? |
@diegoleme - That would be great. If you could take a look at the changed items in this pull request (from the "Files Changed" tab above), and compare them against the associated strings in the English version (https://github.com/adobe/brackets/blob/master/src/nls/root/strings.js), that would be great. Add any comments inline in the "Files Changed" tab. |
Unassigning for now so we can reassign. (But @TomMalbran, if you have time and could help shepherd this through that would be great. For languages we don't speak, we usually just take a look at the feedback from the language reviewer and make sure it gets properly incorporated by the original filer, and then double-check to make sure functionality isn't broken by embedded tags getting messed up, etc.) |
Oops, it looks like we now have two Portuguese pull requests (this one and #5146) - that last one got stuck in review (and it looks like @MarkLinus wasn't aware of it). @MarkLinus and @rodrigost23 - would one of you like to work on consolidating the two (or perhaps one of you could review the other's work)? @diegoleme - let's wait until we hear from the filers before moving forward. |
@njx Sure, I'll review his pull request |
Thanks @MarkLinus! |
@MarkLinus Hello Mark, were you able to review? |
Hi, @couzteau. Yeah, unfortunatelly, I got busy with my school exams, but I think that as of next monday I'll have time to do it. However, I have already checked the first 100 lines and there wasn't any mistranslations, just a few words that I'd translate differently. |
Thank you @MarkLinus. Much appreciated |
@couzteau Done! I've reviewed the translation suggested by @rodrigost23 in [https://github.com//pull/5146] |
Thanks @MarkLinus, @rodrigost23 I'll be happy to merge once the pull has been updated. |
Since this request is a duplicate of [https://github.com//issues/5146], which is now reviewed, I'm closing it. |
@MarkLinus In order to update other people's pull requests you'll need commiter permissions on the other rperson's repo. Usually that's not the case in the common open source workflow. However I think you did the right thing, that is, consolidate the pull requests. |
Added new entries and translations.
Also removed entries that aren't used in Sprint 31