This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Reinitiate tooling service on Node process crash #14724
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All tooling extensions dependent on LanguageClient module in Brackets must only initiate tooling service post the initialization of the module on Node side. On cold launch, we were waiting for the initialization and only then loading the respective client domain. However, when the node process crashes due to any issue, both the language server, as well as the initialized state in the node process are lost. The client then becomes useless.
Solution: Broadcasting an event in the Brackets context to inform the client to reinitiate tooling service once the node process is back up and initialized with LanguageClient module information.
Adding reference handling of the event in the PhpTooling extension.
ping @narayani28 @swmitra @niteskum for review.