Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Reinitiate tooling service on Node process crash #14724

Merged
merged 6 commits into from
Apr 25, 2019
Merged

Conversation

shubhsnov
Copy link
Collaborator

@shubhsnov shubhsnov commented Apr 24, 2019

All tooling extensions dependent on LanguageClient module in Brackets must only initiate tooling service post the initialization of the module on Node side. On cold launch, we were waiting for the initialization and only then loading the respective client domain. However, when the node process crashes due to any issue, both the language server, as well as the initialized state in the node process are lost. The client then becomes useless.

Solution: Broadcasting an event in the Brackets context to inform the client to reinitiate tooling service once the node process is back up and initialized with LanguageClient module information.

Adding reference handling of the event in the PhpTooling extension.

ping @narayani28 @swmitra @niteskum for review.

Copy link
Collaborator

@swmitra swmitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants