Fix Brackets Live Development Issues with Chrome OSX #359
Conversation
…a (e.g. instead of manually parsing process-related arguments).
ghost
assigned 
|
This seems to work, but I'm hitting a crash. Try this:
Results FYI, I was already happy with the functionality of how LD was working with Chrome, so I'm not sure what your latest changes are trying to fix. Maybe try reverting commits back to this comment and work on figuring out the @try/@catch problem. |
|
Yes, that fixes it for me. I will start my final code review of the brackets-shell code. |
| } | ||
| } | ||
| return false; | ||
| return GetLiveBrowser() ? YES : NO; |
There was a problem hiding this comment.
This function signature has a return of bool, so this should be:
return (GetLiveBrowser()) ? true : false;
|
Done with review. |
|
Works well for me now. |
|
|
||
| private: | ||
| // private so this class cannot be instantiated externally | ||
| LiveBrowserMgrMac(); | ||
| virtual ~LiveBrowserMgrMac(); | ||
|
|
||
| int m_openLiveBrowserRetryCount; |
There was a problem hiding this comment.
This needs to be initialized in actor
|
This looks good! I tested on Windows and did not see any problems. Last thing to do is to squash all of the commits in both brackets-shell and brackets. |
|
Want me to force push into this or create a new pull? |
|
I find it easier to create a new branch and a new pull request, but if you can squash this branch that's ok too. |
|
I agree with you on the former. Created new pull request (see #371). |
|
Replaced by #371. Closing this one. |
This provides better real-time detection/separation of Chrome debug sessions, as well as better connectivity + window/tab management from within Brackets.
This requires brackets pull request adobe/brackets#5569