[CLOSED] Adding missing call to native.closeLiveBrowser()

[core-ai-bot]

Issue by fungl164
Friday Oct 18, 2013 at 18:09 GMT
Originally opened as adobe/brackets#5569

---

This should trigger the appropriate calls to handle the LiveBrowser state on the native side for OSX.

This requires brackets-shell pull request adobe/brackets-shell#359

---

fungl164 included the following code: https://github.com/adobe/brackets/pull/5569/commits

[core-ai-bot]

Comment by redmunds
Friday Oct 18, 2013 at 22:00 GMT

---

All of my basic test cases are working perfectly! Thanks for sticking with this!

We still need to figure out how to get the@try/@catch to compile in brackets-shell. And I need to make a final pass through the brackets-shell code.

[core-ai-bot]

Comment by redmunds
Friday Oct 18, 2013 at 22:01 GMT

---

@fungl164 Note: make comments in the Files Changed tab of pull request (and not directly in the commit) so they don't get lost.

I like the idea of displaying the "err", but it should get displayed in addition to (not in place of) the "reason". Maybe something like:

fail(function (err) { 
    if (err) {
        reason += " (" err + ")"
    }
    _setStatus(STATUS_INACTIVE, reason || "explicit_close"); 
}

[core-ai-bot]

Comment by fungl164
Friday Oct 18, 2013 at 23:04 GMT

---

With regards to @try/@catch, I think it would be useful to find out why XCode 4 is resisting. Knowing what I know now, I'm also considering bypassing the ScriptingBridge for now and going back to making lower-level system calls via sysctl. This would fix the compilation issues for sure.

[core-ai-bot]

Comment by redmunds
Friday Nov 01, 2013 at 18:28 GMT

---

Done with review.

[core-ai-bot]

Comment by redmunds
Tuesday Nov 05, 2013 at 16:10 GMT

---

Looks good. This is ready to merge when adobe/brackets-shell#359 is ready.

[core-ai-bot]

Comment by redmunds
Tuesday Nov 05, 2013 at 16:20 GMT

---

@fungl164 You'll need to agree to the Brackets CLA before I can merge your code.

[core-ai-bot]

Comment by fungl164
Tuesday Nov 05, 2013 at 16:24 GMT

---

Cool!

[core-ai-bot]

Comment by redmunds
Wednesday Nov 06, 2013 at 00:16 GMT

---

Merging.