Skip to content
This repository has been archived by the owner on Sep 2, 2021. It is now read-only.

Display error message for invalid zip errors #69

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Display error message for invalid zip errors #69

wants to merge 1 commit into from

Conversation

marcelgerber
Copy link
Contributor

If an error occurs in decompressZip, the returned error will be displayed to the user.
This hopefully helps tracking down adobe/brackets#7387.

Diff of package-validator.js:

 function extractAndValidateFiles(zipPath, extractDir, options, callback) {
     var unzipper = new DecompressZip(zipPath);
     unzipper.on("error", function (err) {
         // General error to report for problems reading the file
         callback(null, {
-            errors: [[Errors.INVALID_ZIP_FILE, zipPath]]
+            errors: [[Errors.INVALID_ZIP_FILE, zipPath, err]]
         });
         return;
     });

@redmunds
Copy link

@marcelgerber You need to update package-validator.js in Brackets, and then update brackets-extensibility.tgx from Brackets.

@peterflynn
Copy link
Member

@marcelgerber Does the .tgz change here still match the package-validator change that landed in adobe/brackets#10343? If so then @redmunds is this ok to merge now?

@marcelgerber
Copy link
Contributor Author

It doesn't include the updated version number in package.json.
I too think we should wait for Ingo's dependency upgrade PR to be merged first.

@ficristo
Copy link
Collaborator

I assume we are waiting for adobe/brackets#10372 to land

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants