Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Send the error over to the callback if decompress-zip fails #9162

Open
core-ai-bot opened this issue Aug 30, 2021 · 7 comments
Open

Comments

@core-ai-bot
Copy link
Member

Issue by MarcelGerber
Saturday Jan 10, 2015 at 18:27 GMT
Originally opened as adobe/brackets#10343


Required for adobe/brackets-registry#69.


MarcelGerber included the following code: https://github.com/adobe/brackets/pull/10343/commits

@core-ai-bot
Copy link
Member Author

Comment by ingorichter
Wednesday Jan 14, 2015 at 06:44 GMT


LGTM. The formatting in the error dialog needs to be updated to provide a better location for the error message.

@core-ai-bot
Copy link
Member Author

Comment by MarcelGerber
Wednesday Jan 14, 2015 at 13:08 GMT


I don't think there's a need to change the Brackets-internal error message (AFAIK, contrary to the registry, it only ever shows up when there's a real problem with the zip). And changing the server-side error message is part of adobe/brackets-registry#69.

@core-ai-bot
Copy link
Member Author

Comment by ingorichter
Wednesday Jan 14, 2015 at 16:39 GMT


I meant more the formatting of the error dialog. The error message could be more separated from the remaining text of the dialog box.

@core-ai-bot
Copy link
Member Author

Comment by MarcelGerber
Wednesday Jan 14, 2015 at 16:45 GMT


So, do you mean the error dialog in Brackets itself or in the registry?

@core-ai-bot
Copy link
Member Author

Comment by ingorichter
Wednesday Jan 14, 2015 at 16:53 GMT


The error dialog in Brackets

@core-ai-bot
Copy link
Member Author

Comment by ingorichter
Wednesday Jan 14, 2015 at 16:54 GMT


screenshot 2015-01-14 08 53 32

@core-ai-bot
Copy link
Member Author

Comment by MarcelGerber
Saturday Jan 17, 2015 at 21:36 GMT


@ingorichter Would you like to do the change or should I do it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant