dev-v2.0.1 -> staging #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staging -> main for 2.0.0 release
* Remove Kotlin Syntax in api doc Remove Kotlin Syntax in api doc * remove Kotlin syntax for authenticated remove Kotlin syntax for authenticated
* Throw exception on empty id in IdentityItem * Unit test IdentityItem with null or empty ids are removed * Update IdentityItem description to state ctor throws if id is empty * Allow IdentityItem with empty ids but don't add to IdentityMap. Changes previous implementation to ignore IdentityItems with empty ids when adding to an IdentityMap instead of throwing an exception when creating an IdentityItem. Changing the IdentityItem constructor to thow when and id is empty is a major API change which can break existing implementations. * Add functional tests to verify items wth empty ids are not added to IdentityMap * Update IdentityMap code docs to state empty ids are not allowed * Update documentation * Update comment for overloaded IdentityItem constructor. * Reword comment for IdentityMap * Fix link in documentation
* Switch to use Charset.forName("UTF-8").name() in encoding
Switching to use Charset.forName("UTF-8").name() to fix the Illegal Charset Name Exception on Android 6 (API 23). (MOB-19119)
* Add IlegalArgumentException to the try catch.
Add IlegalArgumentException to the try catch.
* append a null to the urlFragment in catch case
append a null to the urlFragment in catch case
Bump up version to 2.0.1
Bump up version to 2.0.1
Codecov Report
@@ Coverage Diff @@
## staging #110 +/- ##
===========================================
+ Coverage 93.36% 93.44% +0.08%
===========================================
Files 12 12
Lines 678 686 +8
Branches 103 104 +1
===========================================
+ Hits 633 641 +8
- Misses 16 17 +1
+ Partials 29 28 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
emdobrin
reviewed
Jul 25, 2023
timkimadobe
approved these changes
Jul 25, 2023
There was a problem hiding this comment.
I think it looks good! I just added some suggested API doc updates in #111 but can merge that one after this too if easier
Update License text and api-reference.md from the review comments
kevinlind
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dev-v2.0.1 -> staging
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: