Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to use Charset.forName("UTF-8").name() in encoding #107

Merged
merged 3 commits into from
Jul 20, 2023

Conversation

cacheung
Copy link
Contributor

Switching to use Charset.forName("UTF-8").name() to fix the Illegal Charset Name Exception on Android 6 (API 23). (MOB-19119).

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Switching to use  Charset.forName("UTF-8").name() to fix the Illegal Charset Name Exception on Android 6 (API 23).  (MOB-19119)
@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #107 (f953db9) into dev-v2.0.1 (08c37a2) will decrease coverage by 0.14%.
The diff coverage is 33.33%.

@@              Coverage Diff               @@
##           dev-v2.0.1     #107      +/-   ##
==============================================
- Coverage       93.58%   93.44%   -0.14%     
==============================================
  Files              12       12              
  Lines             685      686       +1     
  Branches          104      104              
==============================================
  Hits              641      641              
- Misses             16       17       +1     
  Partials           28       28              
Flag Coverage Δ
functional-tests 68.51% <33.33%> (-0.10%) ⬇️
unit-tests 93.15% <33.33%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...adobe/marketing/mobile/edge/identity/URLUtils.java 77.27% <33.33%> (-3.68%) ⬇️

cacheung added 2 commits July 19, 2023 14:53
Add IlegalArgumentException to the try catch.
append a null to the urlFragment in catch case
@kevinlind kevinlind merged commit 4299593 into adobe:dev-v2.0.1 Jul 20, 2023
@cacheung cacheung deleted the Android23Fix branch May 30, 2024 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants