Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev -> staging (Core 3.1.2) #709

Merged
merged 7 commits into from
Aug 30, 2024
Merged

dev -> staging (Core 3.1.2) #709

merged 7 commits into from
Aug 30, 2024

Conversation

praveek
Copy link
Contributor

@praveek praveek commented Aug 30, 2024

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sorry, something went wrong.

yangyansong-adbe and others added 7 commits July 31, 2024 11:34

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
* update test app

* Update test app for Lifecycle

* address review comments

* Update CoreView.kt

---------

Co-authored-by: Praveen <[email protected]>
Co-authored-by: Prashanth Rudrabhat <[email protected]>

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
[PLATIR-41103] Added dialog for correct screen reader case

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Update test app for smoke tests

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Update versions [Core-3.1.2]
@praveek praveek requested a review from prudrabhat August 30, 2024 21:34
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 5 lines in your changes missing coverage. Please review.

Project coverage is 81.64%. Comparing base (52b69ed) to head (c6d4395).
Report is 14 commits behind head on staging.

Files with missing lines Patch % Lines
...keting/mobile/services/ui/message/views/Message.kt 85.71% 1 Missing and 4 partials ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             staging     #709      +/-   ##
=============================================
+ Coverage      81.62%   81.64%   +0.02%     
+ Complexity      2151     2150       -1     
=============================================
  Files            192      192              
  Lines           8949     8975      +26     
  Branches        1122     1125       +3     
=============================================
+ Hits            7304     7327      +23     
- Misses          1089     1090       +1     
- Partials         556      558       +2     
Flag Coverage Δ
functional-tests 27.83% <85.71%> (+0.15%) ⬆️
unit-tests 69.24% <0.00%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...keting/mobile/services/ui/message/views/Message.kt 83.05% <85.71%> (-4.83%) ⬇️

... and 3 files with indirect coverage changes

@praveek praveek merged commit 4451e75 into staging Aug 30, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants