Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLATIR-41103] Added dialog for correct screen reader case #706

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

navratan-soni
Copy link
Contributor

Added dialog in case of UI take over for IAM , for making screen reader only read the content of IAM and not the UI beneath it.

Description

Previously we were adding IAM directly in the activity UI, which, for screen readers, was just another content on the screen. So screen reader always read from top to bottom, regardless of IAM was showing or not.
To make IAM getting read only while it is showing, we need to put it in a component which is a layer above the existing UI. So we chose to go with dialog with this. Also we have kept this behavior only in case of UI takeover is true, else it will block the direct interaction to UI beneath it.

Related Issue

https://jira.corp.adobe.com/browse/PLATIR-41103

Motivation and Context

Same as mentioned in description.

How Has This Been Tested?

Tested for all the existing templates.
Ensured that non-ui take over case also remains the same

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@navratan-soni navratan-soni changed the base branch from main to dev August 21, 2024 17:42
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 5 lines in your changes missing coverage. Please review.

Project coverage is 81.66%. Comparing base (4639ee4) to head (b7e4b39).
Report is 2 commits behind head on dev.

Files Patch % Lines
...keting/mobile/services/ui/message/views/Message.kt 85.71% 1 Missing and 4 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev     #706      +/-   ##
============================================
- Coverage     81.67%   81.66%   -0.01%     
  Complexity     2153     2153              
============================================
  Files           192      192              
  Lines          8949     8975      +26     
  Branches       1122     1125       +3     
============================================
+ Hits           7309     7329      +20     
- Misses         1087     1090       +3     
- Partials        553      556       +3     
Flag Coverage Δ
functional-tests 27.84% <85.71%> (+0.16%) ⬆️
unit-tests 69.26% <0.00%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...keting/mobile/services/ui/message/views/Message.kt 83.05% <85.71%> (-4.83%) ⬇️

... and 2 files with indirect coverage changes

@prudrabhat prudrabhat merged commit 11fe509 into adobe:dev Aug 23, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants