-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from rollup to rolldown #3578
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
fe88c11
Migrate from rollup to rolldown
nstepien 963070a
use defineConfig
nstepien 73b54cc
tweak command
nstepien fe9c16a
Merge branch 'main' into rolldown
nstepien 75da3bc
update rolldown
nstepien 4233c96
Merge branch 'main' into rolldown
nstepien 9b4fe3a
update rolldown
nstepien d03f789
update rolldown config
nstepien 670ba11
don't need this
nstepien 2a4c80d
add todo, remove other comment
nstepien 96ec3fc
remove most babel deps
nstepien 8f7d262
update rolldown
nstepien cc33d16
use output array
nstepien 55e33d6
pin @vitest/eslint-plugin
nstepien File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,18 +1,3 @@ | ||
| { | ||
| "presets": [ | ||
| [ | ||
| "@babel/env", | ||
| { | ||
| "loose": true, | ||
| "bugfixes": true, | ||
| "shippedProposals": true | ||
| } | ||
| ], | ||
| ["@babel/react", { "runtime": "automatic" }], | ||
| "@babel/typescript" | ||
| ], | ||
| "plugins": [ | ||
| "@babel/transform-runtime", | ||
| ["optimize-clsx", { "functionNames": ["getCellClassname"] }] | ||
| ] | ||
| "presets": ["@babel/typescript"] | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| // @ts-check | ||
| import { isAbsolute } from 'node:path'; | ||
| import wyw from '@wyw-in-js/rollup'; | ||
| import pkg from './package.json' with { type: 'json' }; | ||
| import { defineConfig } from 'rolldown'; | ||
|
|
||
| export default defineConfig({ | ||
| input: './src/index.ts', | ||
| output: [ | ||
| { | ||
| dir: 'lib', | ||
| entryFileNames: 'bundle.js', | ||
| cssEntryFileNames: 'styles.css', | ||
| format: 'es', | ||
| sourcemap: true | ||
| }, | ||
| { | ||
| dir: 'lib', | ||
| entryFileNames: 'bundle.cjs', | ||
| cssEntryFileNames: 'styles.css', | ||
| format: 'cjs', | ||
| sourcemap: true | ||
| } | ||
| ], | ||
| platform: 'browser', | ||
| external: (id) => !id.startsWith('.') && !isAbsolute(id), | ||
| plugins: [ | ||
| // @ts-expect-error | ||
| wyw({ | ||
| preprocessor: 'none', | ||
| /** | ||
| * @param {string} hash | ||
| */ | ||
| classNameSlug(hash) { | ||
| // We add the package version as suffix to avoid style conflicts | ||
| // between multiple versions of RDG on the same page. | ||
| return `${hash}${pkg.version.replaceAll('.', '-')}`; | ||
| } | ||
| }) | ||
| ] | ||
| }); |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!