Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from rollup to rolldown #3578

Merged
merged 14 commits into from
Dec 29, 2024
Merged

Migrate from rollup to rolldown #3578

merged 14 commits into from
Dec 29, 2024

Conversation

nstepien
Copy link
Contributor

@nstepien nstepien commented Aug 16, 2024

@nstepien nstepien self-assigned this Aug 16, 2024
Copy link

codecov bot commented Dec 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.06%. Comparing base (7f9fd89) to head (55e33d6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3578      +/-   ##
==========================================
+ Coverage   89.75%   91.06%   +1.30%     
==========================================
  Files          48       48              
  Lines        3457     3457              
  Branches      653      672      +19     
==========================================
+ Hits         3103     3148      +45     
+ Misses        354      309      -45     

see 10 files with indirect coverage changes

@nstepien
Copy link
Contributor Author

@amanmahajan7 rolldown seems to work great now!
I'll open a few issues upstream first.

@nstepien nstepien marked this pull request as ready for review December 23, 2024 17:31
Copy link
Contributor

@amanmahajan7 amanmahajan7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the bundle same as before?

@@ -55,21 +55,14 @@
"clsx": "^2.0.0"
},
"devDependencies": {
"@babel/core": "^7.26.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

tsconfig.js.json Show resolved Hide resolved
rolldown.config.js Outdated Show resolved Hide resolved
@nstepien
Copy link
Contributor Author

Is the bundle same as before?

I've compared the bundle output after running prettier on the output files:

Copy link
Contributor

@amanmahajan7 amanmahajan7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can manually optimize clsx calls. Not sure how much difference it makes in performance though

@nstepien
Copy link
Contributor Author

Probably not worth the effort.

@nstepien nstepien merged commit 4faa0a1 into main Dec 29, 2024
3 checks passed
@nstepien nstepien deleted the rolldown branch December 29, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants