-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from rollup to rolldown #3578
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3578 +/- ##
==========================================
+ Coverage 89.75% 91.06% +1.30%
==========================================
Files 48 48
Lines 3457 3457
Branches 653 672 +19
==========================================
+ Hits 3103 3148 +45
+ Misses 354 309 -45 |
@amanmahajan7 rolldown seems to work great now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the bundle same as before?
@@ -55,21 +55,14 @@ | |||
"clsx": "^2.0.0" | |||
}, | |||
"devDependencies": { | |||
"@babel/core": "^7.26.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
I've compared the bundle output after running prettier on the output files:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can manually optimize clsx calls. Not sure how much difference it makes in performance though
Probably not worth the effort. |
https://rolldown.rs/
https://www.npmjs.com/package/rolldown
https://github.com/rolldown/rolldown