Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking ID's only work in en folder #370

Closed
zenduo opened this issue May 31, 2014 · 6 comments · Fixed by #1039
Closed

Tracking ID's only work in en folder #370

zenduo opened this issue May 31, 2014 · 6 comments · Fixed by #1039

Comments

@zenduo
Copy link
Contributor

zenduo commented May 31, 2014

In the gruntfile.js file, the following code only works for the 'en' folder.

adapt_insert_tracking_ids: {
          options: {
              courseFile: "src/course/en/course.json",
              blocksFile: "src/course/en/blocks.json"
          }
        },
@zenduo zenduo added the bug label May 31, 2014
@darylhedley
Copy link
Contributor

@zenduo - Does "src/course/**/course.json" work?

@oliverfoster
Copy link
Member

@moloko
Copy link
Contributor

moloko commented Dec 3, 2014

@zenduo is this something that needs doing for the next release? Are people actually using folders other than 'en' yet?

@taylortom
Copy link
Member

This'll likely require quite a bit of rethinking and refactoring.

If we're going to support the languages folder properly, we need to have the ability to output multiple builds (a version has been set up here: https://github.com/cgkineo/adapt-grunt), otherwise it's pretty pointless.

@moloko
Copy link
Contributor

moloko commented Dec 10, 2014

unless anyone has any objections I'm going to drop this from the v2 release and it can be picked up later

@moloko
Copy link
Contributor

moloko commented Jan 6, 2015

no objections heard, so have dropped from v2 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants