Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

select lang folder for grunt build #1053

Closed
lc-thomasberger opened this issue May 11, 2016 · 5 comments
Closed

select lang folder for grunt build #1053

lc-thomasberger opened this issue May 11, 2016 · 5 comments

Comments

@lc-thomasberger
Copy link
Member

update grunt build process, so that a list of language folders can be defined that are used for the build

@dancgray
Copy link
Member

dancgray commented Jul 1, 2016

Also see #370

@dancgray
Copy link
Member

dancgray commented Jul 1, 2016

Building different lang folders seems to now be supported in RUB https://github.com/cgkineo/adapt-buildkit-rub, (which looks awesome BTW). @oliverfoster are there any plans for RUB to become more 'core'?

@oliverfoster
Copy link
Member

um, that's a good question.
there are a few things i'd like to do with the framework and i'm trying to figure out how at the moment.

  • separate + simplify the plugin architecture from adapt framework (this will allow us to greatly expand the Adapt ecosystem by reducing the complexity, upping the flexibility and engaging people in different architectural layers, which can make things more robust etc etc i hope)
  • combine the build tool + plugin management into one utility (RUB is a work in progress which helps Kineo with its production line but is also a way of me exploring how to make command line utilities, it doesn't have plugin management in it yet. this idea of properly engaging plugin management is that version control and dependencies are really important to us getting the stack right and stable)
  • create a bower registry with unregister functionality (almost done)

so, to answer your question... we could make rub core tomorrow... but it isn't a traditional build tool, in that it doesn't use grunt/gulp/etc (so is kinda frowned upon by traditional open source standards - rule 1: never make your own builder) and it is also not a very good solution to the overall problems we currently have.

@lc-thomasberger
Copy link
Member Author

The idea behind this issue is that you can define the languages you would like to include into the build.
This might be useful if you create multiple ML-course bundles.
It is just an enhancement, to make life easier for the course developers.

grunt build --languages="de,fr,it" <-- will create a build, including only this languages

@dancgray
Copy link
Member

dancgray commented Jul 5, 2016

+1, thanks for the explanation.

@dancgray dancgray self-assigned this Jul 5, 2016
lc-thomasberger added a commit that referenced this issue Jul 13, 2016
@moloko moloko closed this as completed Sep 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants