Refactoring of the grunt build tool #891
Conversation
Had to separate all tasks into separate files
Help is currently broken, as jit-grunt is async
So can now apply a filter
- The config file should be read in from the path passed in as an argument - Logging enabled on 'server-build' task - Commented out the verbose logging for excluded plugins for the time being
Add jshint and jscs
Conflicts: package.json
| if (options.plugins) { | ||
| var pluginsClientSidePatch = 'requirejs.config({map: { "*": { "extensions/extensions":"'+options.pluginsModule+'","menu/menu":"'+options.pluginsModule+'","theme/theme":"'+options.pluginsModule+'","components/components":"'+options.pluginsModule+'" } } });'; | ||
|
|
||
| if (!fs.existsSync(options.pluginsPath)) { |
There was a problem hiding this comment.
I think existsSync() has been deprecated. Can you consider using statSync() here instead?
|
|
|
@oliverfoster was just about to do that, thanks 😁 |
|
✋ 🌴 🍻 |
|
can probably remove the console.log from https://github.com/adaptlearning/adapt_framework/blob/ABU-680/grunt/helpers.js#L51 now |
|
+1 var testedOn = {"linux & mac" : "terminal", "windows10": [ "git-bash", "command line" ] }; |
|
+1 (tested on windows) |
|
+1 (tested in Authoring tool on mac) |
|
I'm assuming JSHint and JSCS still aren't fully integrated? I'm not seeing any alerts from them, is that as expected? If so then +1 (tested on Win 7 using Node v0.10.35 and cmder) |
|
+1 -- tested on |
|
@moloko correct, you need to specifically run the commands at the moment. I've created a separate ticket to integrate these into travis. If anyone else has some ideas about how we go about integrating this (if at all), will update this PR. @brian-learningpool @oliverfoster @dancgray @lc-thomasberger ...otherwise, let's get this baby merged! 💃💃 |
|
go for it |
Refactoring of the grunt build tool
What's new!
grunt/config- uses load-grunt-config)grunt/tasks)Instructions for testing!
node_modulesfolder!npm install && grunt build && grunt server!If testing with the authoring tool, be aware that updating the git repo in
/tempwill cause certain deleted files/folders to be reinstated, so these will need to be manually removed (I think the main folder affected issrc/course).