Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a check for NodeJS version #662

Merged
merged 2 commits into from
May 5, 2015
Merged

Added a check for NodeJS version #662

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db6bf3b
Added a check for NodeJS version
brian-learningpool Apr 27, 2015
420df9d
Re-worded NodeJS warning message
brian-learningpool May 5, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/application.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,6 +308,11 @@ Origin.prototype.startServer = function () {
serverOptions.minimal = true;
}

// Check the NodeJS version
if (process.version !== 'v0.10.33') {
logger.log('warn', 'Incorrect version of NodeJS required -- this code requires v0.10.33 to run correctly.');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the message could worded a little better, here. I suggest:
"You are running an unsupported version of NodeJS (" + process.version + "). This application has only been fully tested on NodeJS v0.10.33. It is recommended that you use that version instead."

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me fail English? That's unpossible.

PR updated. ;)

}

var app = this;
app.createServer(serverOptions, function (error, server) {
if (error) {
Expand Down