Added a check for NodeJS version #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will generate a warning if not v0.10.33.
|
Resolves #660. |
|
+1 |
|
I don't think it's needed anywhere else, and could possibly be removed when we re-work the code for v0.12. |
| @@ -308,6 +308,11 @@ Origin.prototype.startServer = function () { | |||
| serverOptions.minimal = true; | |||
| } | |||
|
|
|||
| // Check the NodeJS version | |||
| if (process.version !== 'v0.10.33') { | |||
| logger.log('warn', 'Incorrect version of NodeJS required -- this code requires v0.10.33 to run correctly.'); | |||
There was a problem hiding this comment.
I think the message could worded a little better, here. I suggest:
"You are running an unsupported version of NodeJS (" + process.version + "). This application has only been fully tested on NodeJS v0.10.33. It is recommended that you use that version instead."
There was a problem hiding this comment.
Me fail English? That's unpossible.
PR updated. ;)
|
+1 |
|
+1 ralphie |
brian-learningpool
added a commit
that referenced
this pull request
May 5, 2015
Added a check for NodeJS version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will generate a warning if not v0.10.33.