Add support for FROM and GRAPH with fixed IRI
#1445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is yet very hacky, and we have to integrate all the other things.
TODO<joka921> integrate and test it.
maybe later.
Figure out the constantness of the result...
correct behavior with SetOfIntervals.
# Conflicts: # src/index/IndexFormatVersion.h # src/index/IndexImpl.cpp # src/index/PatternCreator.cpp # src/index/PatternCreator.h # src/parser/TripleComponent.h
fix the whole stuff....
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1445 +/- ##
==========================================
- Coverage 92.55% 88.21% -4.35%
==========================================
Files 355 355
Lines 26631 26639 +8
Branches 3575 3583 +8
==========================================
- Hits 24649 23499 -1150
+ Misses 1940 1909 -31
- Partials 42 1231 +1189 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Johannes Kalmbach <[email protected]>
Signed-off-by: Johannes Kalmbach <[email protected]>
# Conflicts: # src/index/CompressedRelation.cpp # src/index/CompressedRelation.h # test/CompressedRelationsTest.cpp
Signed-off-by: Johannes Kalmbach <[email protected]>
Signed-off-by: Johannes Kalmbach <[email protected]>
Signed-off-by: Johannes Kalmbach <[email protected]>
Signed-off-by: Johannes Kalmbach <[email protected]>
Signed-off-by: Johannes Kalmbach <[email protected]>
hannahbast
changed the title
hannahbast
requested changes
Sep 25, 2024
There was a problem hiding this comment.
First round of reviewing of diff to #1482, looks great already
Check whether the change in SparqlExpressionTypes.h is necessary
Dito for LiteralExpression.h
Dito for Result.cpp
Dito for Bind.cpp
Signed-off-by: Johannes Kalmbach <[email protected]>
Signed-off-by: Johannes Kalmbach <[email protected]>
Signed-off-by: Johannes Kalmbach <[email protected]>
Signed-off-by: Johannes Kalmbach <[email protected]>
Signed-off-by: Johannes Kalmbach <[email protected]>
hannahbast
requested changes
Sep 26, 2024
Signed-off-by: Johannes Kalmbach <[email protected]>
hannahbast
changed the title
FROM and GRAPH with fixed IRI
hannahbast
approved these changes
Sep 26, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues work from #1337 (add a column with the graph name to the index), #1444 (add parser for N-Quads), and #1482 (add graph info to block metadata). Queries with
FROMand/orGRAPHwith a fixed IRI can now be processed. Processing queries withFROM NAMEorGRAPHwith a variable will be implemented in a future PR.