Add fourth column for graph name #1337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is yet very hacky, and we have to integrate all the other things.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1337 +/- ##
==========================================
- Coverage 89.38% 89.36% -0.03%
==========================================
Files 345 345
Lines 24881 24945 +64
Branches 3307 3312 +5
==========================================
+ Hits 22241 22293 +52
- Misses 1500 1501 +1
- Partials 1140 1151 +11 ☔ View full report in Codecov by Sentry. |
|
hannahbast
requested changes
Aug 19, 2024
hannahbast
changed the title
hannahbast
requested changes
Aug 19, 2024
hannahbast
approved these changes
Aug 21, 2024
hannahbast
changed the title
Merged
|
joka921
added a commit
that referenced
this pull request
Aug 27, 2024
Add a parser for N-Quads and write the graph label to the new column introduced by #1337 . Now `IndexBuilderMain` supports three file types: `nt`, `tll`, and `nq`.
hannahbast
pushed a commit
that referenced
this pull request
Sep 27, 2024
This continues work from #1337 (add a column with the graph name to the index), #1444 (add parser for N-Quads), and #1482 (add graph info to block metadata). Queries with `FROM` and/or `GRAPH` with a fixed IRI can now be processed. Processing queries with `FROM NAME` or `GRAPH` with a variable will be implemented in a future PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All six permutation pairs (SPO, SOP, OSP, OPS, PSO, POS) now have an additional column for the graph name. It is the fourth column (before the two columns for the patterns). For now, all internal triples get a special internal graph name, and all other triples belong to the default graph.
IMPORTANT: This changes the index format. It also slows down the indexing by about 15% (which is reasonable, given that the number of columns increased from 5 to 6).