Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ProxyAccessor constructor can now be constexpr #3757

Merged
merged 7 commits into from
Nov 5, 2024
Merged

feat: ProxyAccessor constructor can now be constexpr #3757

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
134659d
ProxyAccessor constructor can now be constexpr
timadye Oct 17, 2024
ed72376
format
timadye Oct 17, 2024
9aa1811
fix unused warning
timadye Oct 24, 2024
951167e
Merge branch 'main' into patch-5
paulgessinger Oct 25, 2024
0067c89
Merge branch 'main' into patch-5
paulgessinger Oct 26, 2024
fe5a99c
Merge branch 'main' into patch-5
AJPfleger Oct 27, 2024
e547cc4
Merge branch 'main' into patch-5
kodiakhq[bot] Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Core/include/Acts/EventData/ProxyAccessor.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,8 @@ struct ProxyAccessorBase {

/// Create the accessor from a string key
/// @param _key the key
ProxyAccessorBase(const std::string& _key) : key{hashString(_key)} {}
constexpr ProxyAccessorBase(const std::string& _key)
: key{hashString(_key)} {}

/// Access the stored key on the proxy given as an argument. Mutable version
/// @tparam proxy_t the type of the proxy
Expand Down
1 change: 1 addition & 0 deletions Tests/UnitTests/Core/EventData/TrackContainerComplianceTests.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ ACTS_DOES_NOT_COMPILE_SUITE_BEGIN(BuildFromConstRef)
(void)t;

ConstProxyAccessor<unsigned int> caccNMeasuements("nMeasurements");
static_cast<void>(caccNMeasuements); // suppressed unused warning
ACTS_DOES_NOT_COMPILE_BEGIN(ConstAccessorMutate)
caccNMeasuements(t) = 66;
ACTS_DOES_NOT_COMPILE_END()
Expand Down
Loading