feat: ProxyAccessor constructor can now be constexpr #3757

timadye · 2024-10-17T14:29:11Z

Since C++20 supports constexpr std::string, we can make ProxyAccessorBase(const std::string& _key) constructor constexpr.

github-actions · 2024-10-17T16:35:44Z

📊: Physics performance monitoring for `e547cc4`

Full contents

physmon summary

paulgessinger · 2024-10-17T20:29:00Z

Makes sense. There's one unit test failure on macOS related to an unused variable.

timadye · 2024-10-18T16:27:11Z

Makes sense. There's one unit test failure on macOS related to an unused variable.

So the warning is here:

/Users/runner/work/acts/acts/build/Tests/UnitTests/Core/EventData/TrackContainerComplianceTests.cpp:77:36: error: unused variable 'caccNMeasuements' [-Werror,-Wunused-variable]
  ConstProxyAccessor<unsigned int> caccNMeasuements("nMeasurements");

Indeed, that variable is not used, because it is just used to check that you can't modify through a ConstProxyAccessor. I don't understand why this warning wasn't always there, and only appears now this constructor is constexpr.

That aside, do you have any ideas on how to fix this?

paulgessinger · 2024-10-24T08:18:30Z

@timadye maybe

diff --git a/Tests/UnitTests/Core/EventData/TrackContainerComplianceTests.cpp b/Tests/UnitTests/Core/EventData/TrackContainerComplianceTests.cpp
index 636b30bff5..731f9e01a4 100644
--- a/Tests/UnitTests/Core/EventData/TrackContainerComplianceTests.cpp
+++ b/Tests/UnitTests/Core/EventData/TrackContainerComplianceTests.cpp
@@ -75,6 +75,7 @@ ACTS_DOES_NOT_COMPILE_SUITE_BEGIN(BuildFromConstRef)
   (void)t;
 
   ConstProxyAccessor<unsigned int> caccNMeasuements("nMeasurements");
+  static_cast<void>(caccNMeasuements);  // suppressed unused warning
   ACTS_DOES_NOT_COMPILE_BEGIN(ConstAccessorMutate)
   caccNMeasuements(t) = 66;
   ACTS_DOES_NOT_COMPILE_END()

timadye · 2024-10-25T11:12:44Z

The macos build failure looks like an unrelated configuration problem (XercesC 3.2.5 instead of 3.3.0). Hopefully this can be fixed soon and we can see if the last update fixes the warning.

paulgessinger · 2024-10-25T17:49:38Z

In principle there should be a fix for this already. Maybe it's not merged yet

timadye · 2024-11-05T13:13:35Z

@AJPfleger I think this is waiting for your approval, if you do approve. Thanks!

coderabbitai · 2024-11-05T14:07:49Z

Important

Review skipped

Auto reviews are limited to specific labels.

🏷️ Labels to auto review (1)

coderabbit

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

sonarqubecloud · 2024-11-05T16:13:34Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

acts-project-service · 2024-11-07T13:46:06Z

🔴 Athena integration test results

Build job with this PR failed!

Please investigate the build job for the pipeline!

Since C++20 supports `constexpr std::string`, we can make `ProxyAccessorBase(const std::string& _key)` constructor `constexpr`.

timadye added 2 commits October 17, 2024 15:25

ProxyAccessor constructor can now be constexpr

134659d

format

ed72376

github-actions bot added Component - Core Affects the Core module Event Data Model labels Oct 17, 2024

paulgessinger added this to the next milestone Oct 17, 2024

AJPfleger self-requested a review October 22, 2024 15:27

fix unused warning

9aa1811

Merge branch 'main' into patch-5

951167e

paulgessinger and others added 2 commits October 26, 2024 09:56

Merge branch 'main' into patch-5

0067c89

Merge branch 'main' into patch-5

fe5a99c

AJPfleger approved these changes Nov 5, 2024

View reviewed changes

AJPfleger added the automerge label Nov 5, 2024

Merge branch 'main' into patch-5

e547cc4

kodiakhq bot merged commit 8c1f155 into acts-project:main Nov 5, 2024
43 checks passed

github-actions bot removed the automerge label Nov 5, 2024

acts-project-service added the Breaks Athena build This PR breaks the Athena build label Nov 7, 2024

paulgessinger modified the milestones: next, v37.4.0 Nov 8, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: ProxyAccessor constructor can now be constexpr #3757

feat: ProxyAccessor constructor can now be constexpr #3757

timadye commented Oct 17, 2024 •

edited

Loading

github-actions bot commented Oct 17, 2024 •

edited

Loading

paulgessinger commented Oct 17, 2024

timadye commented Oct 18, 2024

paulgessinger commented Oct 24, 2024

timadye commented Oct 25, 2024

paulgessinger commented Oct 25, 2024

timadye commented Nov 5, 2024

coderabbitai bot commented Nov 5, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

sonarqubecloud bot commented Nov 5, 2024

acts-project-service commented Nov 7, 2024

feat: ProxyAccessor constructor can now be constexpr #3757

feat: ProxyAccessor constructor can now be constexpr #3757

Conversation

timadye commented Oct 17, 2024 • edited Loading

github-actions bot commented Oct 17, 2024 • edited Loading

📊: Physics performance monitoring for e547cc4

physmon summary

paulgessinger commented Oct 17, 2024

timadye commented Oct 18, 2024

paulgessinger commented Oct 24, 2024

timadye commented Oct 25, 2024

paulgessinger commented Oct 25, 2024

timadye commented Nov 5, 2024

coderabbitai bot commented Nov 5, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

sonarqubecloud bot commented Nov 5, 2024

Quality Gate passed

acts-project-service commented Nov 7, 2024

🔴 Athena integration test results

Build job with this PR failed!

timadye commented Oct 17, 2024 •

edited

Loading

github-actions bot commented Oct 17, 2024 •

edited

Loading

📊: Physics performance monitoring for `e547cc4`

CodeRabbit Configuration File (`.coderabbit.yaml`)