Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add default value to ReadOnly in ScoreBasedAmbiguityResolution #3418

Merged
merged 2 commits into from
Jul 19, 2024
Merged

fix: add default value to ReadOnly in ScoreBasedAmbiguityResolution #3418

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
345c6eb
add default value to ReadOnly
Ragansu Jul 19, 2024
79a8b00
Merge branch 'main' into patch_score_based_ambi
kodiakhq[bot] Jul 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Core/include/Acts/AmbiguityResolution/ScoreBasedAmbiguityResolution.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ class ScoreBasedAmbiguityResolution {
/// good enough, based on some criteria. Users are free to add their own cuts
/// with the help of this struct.
template <typename track_container_t, typename traj_t,
template <typename> class holder_t, bool ReadOnly>
template <typename> class holder_t, bool ReadOnly = true>
struct OptionalCuts {
using OptionalFilter =
std::function<bool(const Acts::TrackProxy<track_container_t, traj_t,
Expand Down Expand Up @@ -162,7 +162,7 @@ class ScoreBasedAmbiguityResolution {
/// @param optionalCuts is the user defined optional cuts to be applied.
/// @return a vector of scores for each track
template <typename track_container_t, typename traj_t,
template <typename> class holder_t, bool ReadOnly>
template <typename> class holder_t, bool ReadOnly = true>
std::vector<double> simpleScore(
const TrackContainer<track_container_t, traj_t, holder_t>& tracks,
const std::vector<std::vector<TrackFeatures>>& trackFeaturesVectors,
Expand All @@ -176,7 +176,7 @@ class ScoreBasedAmbiguityResolution {
/// @param optionalCuts is the user defined optional cuts to be applied.
/// @return a vector of scores for each track
template <typename track_container_t, typename traj_t,
template <typename> class holder_t, bool ReadOnly>
template <typename> class holder_t, bool ReadOnly = true>
std::vector<double> ambiguityScore(
const TrackContainer<track_container_t, traj_t, holder_t>& tracks,
const std::vector<std::vector<TrackFeatures>>& trackFeaturesVectors,
Expand Down Expand Up @@ -206,7 +206,7 @@ class ScoreBasedAmbiguityResolution {
/// @param optionalCuts is the optional cuts to be applied
/// @return a vector of IDs of the tracks we want to keep
template <typename track_container_t, typename traj_t,
template <typename> class holder_t, bool ReadOnly>
template <typename> class holder_t, bool ReadOnly = true>
std::vector<int> solveAmbiguity(
const TrackContainer<track_container_t, traj_t, holder_t>& tracks,
const std::vector<std::vector<MeasurementInfo>>& measurementsPerTrack,
Expand Down
Loading