Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add default value to ReadOnly in ScoreBasedAmbiguityResolution #3418

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

Ragansu
Copy link
Contributor

@Ragansu Ragansu commented Jul 19, 2024

In the ScoreBasedAmbiguityResolution There is a template parameter "ReadOnly" which didn't have a default parameter.
This cause issues if there is no optional cuts implemented.

This PR is a fix for that.

Thank You

Ragansu Chakkappai

Copy link
Contributor

@Corentin-Allaire Corentin-Allaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed this in person and it looks good to me.

Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is where passing the actual track container type instead of repeating it's template arguments through would simplify things

@andiwand andiwand added this to the next milestone Jul 19, 2024
Copy link

@kodiakhq kodiakhq bot merged commit d493563 into acts-project:main Jul 19, 2024
44 checks passed
@paulgessinger paulgessinger modified the milestones: next, v36.1.0 Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants