-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add default value to ReadOnly in ScoreBasedAmbiguityResolution #3418
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We discussed this in person and it looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is where passing the actual track container type instead of repeating it's template arguments through would simplify things
📊: Physics performance monitoring for 79a8b00physmon summary
|
|
In the ScoreBasedAmbiguityResolution There is a template parameter "ReadOnly" which didn't have a default parameter.
This cause issues if there is no optional cuts implemented.
This PR is a fix for that.
Thank You
Ragansu Chakkappai