Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: Use std::string_view for addColumn in track EDM #3187

Merged
merged 2 commits into from
May 15, 2024
Merged

refactor!: Use std::string_view for addColumn in track EDM #3187

merged 2 commits into from
May 15, 2024

Conversation

andiwand
Copy link
Contributor

This makes it easier for compile time known dynamic columns to add. Pulled out of #3161

@andiwand andiwand added this to the next milestone May 15, 2024
@github-actions github-actions bot added Component - Core Affects the Core module Component - Plugins Affects one or more Plugins Event Data Model labels May 15, 2024
@andiwand andiwand mentioned this pull request May 15, 2024
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented May 15, 2024 •
edited
Loading

📊: Physics performance monitoring for d0dce11

Full contents

physmon summary

AJPfleger
AJPfleger approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@AJPfleger AJPfleger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this already updating all cases of 'const std::string&'?

@kodiakhq kodiakhq bot merged commit 7120c6b into acts-project:main May 15, 2024
52 checks passed
@andiwand andiwand deleted the refactor-track-edm-string-view branch May 15, 2024 22:37
@acts-project-service
Copy link
Collaborator

acts-project-service commented May 15, 2024 •
edited
Loading

✅ Athena integration test results [7120c6b]

✅ All tests successful

status job report
🟢 run_unit_tests
🟢 test_ActsEFTrackFit
🟢 test_ActsPersistifySeeds
🟢 test_ActsBenchmarkWithSpot
🟢 test_ActsAnalogueClustering
🟢 test_ActsConversionWorkflow
🟢 test_ActsWorkflowHeavyIons
🟢 test_ActsWorkflowFastTracking
🟢 test_ActsWorkflowCached
🟢 test_ActsWorkflow
🟢 test_ActsValidateAmbiguityResolution
🟢 test_ActsValidateResolvedTracks
🟢 test_ActsValidateTracks
🟢 test_ActsValidateActsCoreSpacePoints
🟢 test_ActsValidateActsSpacePoints
🟢 test_ActsValidateSeeds
🟢 test_ActsValidateOrthogonalSeeds
🟢 test_ActsValidateClusters
🟢 test_ActsPersistifyEDM
🟢 test_ActsGSFRefitting
🟢 test_ActsKfRefitting
🟢 test_ActsExtrapolationAlgTest
🟢 test_ActsITkTest
🟢 run_workflow_tests_run4_mc
🟢 run_workflow_tests_run2_mc
🟢 run_workflow_tests_run2_data
🟢 run_workflow_tests_run3_mc
🟢 run_workflow_tests_run3_data
🟢 run_art_test: test_data18_13TeV_1000evt
🟢 run_art_test: test_ttbarPU40_reco

@acts-project-service acts-project-service added the Breaks Athena build This PR breaks the Athena build label May 15, 2024
@andiwand
Copy link
Contributor Author

I will fix this tomorrow

paulgessinger
paulgessinger reviewed May 16, 2024
View reviewed changes
Copy link
Member

@paulgessinger paulgessinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did this originally because the xAOD backend I believe needs strings. I guess the backend can just make a string from the string view, however.

@andiwand
Copy link
Contributor Author

I did this originally because the xAOD backend I believe needs strings. I guess the backend can just make a string from the string view, however.

I see - I should have checked the xAOD backend first. Creating a string from a string_view is not optimal but at the same time this function should not be high traffic.

@andiwand andiwand modified the milestones: next, v35.0.0 May 17, 2024
asalzburger pushed a commit to asalzburger/acts that referenced this pull request May 21, 2024
@andiwand @asalzburger
refactor!: Use std::string_view for addColumn in track EDM (acts-…
7edcec4 
…project#3187)

This makes it easier for compile time known dynamic columns to add. Pulled out of acts-project#3161
EleniXoch pushed a commit to EleniXoch/acts that referenced this pull request May 31, 2024
@andiwand @EleniXoch
refactor!: Use std::string_view for addColumn in track EDM (acts-…
c04ff3f 
…project#3187)

This makes it easier for compile time known dynamic columns to add. Pulled out of acts-project#3161
Matthewharri pushed a commit to Matthewharri/acts that referenced this pull request Jun 18, 2024
@andiwand
refactor!: Use std::string_view for addColumn in track EDM (acts-…
63fd7da 
…project#3187)

This makes it easier for compile time known dynamic columns to add. Pulled out of acts-project#3161
kodiakhq bot pushed a commit that referenced this pull request Jul 10, 2024
@andiwand @timadye
refactor!: Use track container in Core CKF and pass track proxies t…
6643b83 
…o delegates (#3161)

Wires tracks through Core CKF to track branches and passes those tracks into the branch stopper delegate. This allows the user to count experiment specific track quantities on those branches and then cut on those (e.g. pixel holes).

blocked by
- #3187

Co-authored-by: Tim Adye <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulgessinger paulgessinger paulgessinger left review comments

@AJPfleger AJPfleger AJPfleger approved these changes

Assignees
No one assigned
Labels
Breaks Athena build This PR breaks the Athena build Component - Core Affects the Core module Component - Plugins Affects one or more Plugins Event Data Model
Projects
None yet
Milestone
v35.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@andiwand @acts-project-service @paulgessinger @AJPfleger