Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Use track container in Core CKF and pass track proxies to delegates #3161

Merged
merged 50 commits into from
Jul 10, 2024

Conversation

andiwand
Copy link
Contributor

@andiwand andiwand commented Apr 30, 2024

Wires tracks through Core CKF to track branches and passes those tracks into the branch stopper delegate. This allows the user to count experiment specific track quantities on those branches and then cut on those (e.g. pixel holes).

blocked by

@andiwand andiwand added the 🚧 WIP Work-in-progress label Apr 30, 2024
@andiwand andiwand added this to the next milestone Apr 30, 2024
@github-actions github-actions bot added Component - Core Affects the Core module Component - Examples Affects the Examples module Event Data Model Track Finding labels Apr 30, 2024
@github-actions github-actions bot added Component - Plugins Affects one or more Plugins Ambiguity Resolution labels May 8, 2024
@andiwand andiwand marked this pull request as ready for review May 10, 2024 12:48
@andiwand andiwand removed the 🚧 WIP Work-in-progress label May 10, 2024
@andiwand
Copy link
Contributor Author

@timadye this should allow us to count experiment specific stopping criteria inside the branch stopper without adding state to it but rather store this information on the branches

@github-actions github-actions bot added Infrastructure Changes to build tools, continous integration, ... Changes Performance labels Jul 2, 2024
@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Jul 3, 2024
@andiwand andiwand removed Changes Performance Fails Athena tests This PR causes a failure in the Athena tests labels Jul 9, 2024
@andiwand
Copy link
Contributor Author

andiwand commented Jul 9, 2024

I executed test_ActsWorkflow manually with main--ACTS and it seems to work

@paulgessinger
Copy link
Member

So we think it's just the inconsistency?

@acts-project-service acts-project-service added the Breaks Athena build This PR breaks the Athena build label Jul 9, 2024
@andiwand
Copy link
Contributor Author

I think so - I triggered another run with the modified CI setup. Lets see if that goes through. Otherwise I would suggest to merge these PRs at the end of the day to get them into the nightly and then fix potential problems afterwards.

@andiwand andiwand removed the Breaks Athena build This PR breaks the Athena build label Jul 10, 2024
@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Jul 10, 2024
@andiwand andiwand removed the Fails Athena tests This PR causes a failure in the Athena tests label Jul 10, 2024
@andiwand
Copy link
Contributor Author

Athena is happy now

Copy link

@kodiakhq kodiakhq bot merged commit 6643b83 into acts-project:main Jul 10, 2024
50 checks passed
@andiwand andiwand deleted the refactor-ckf-use-track-container branch July 10, 2024 20:27
@acts-project-service acts-project-service added the Breaks Athena build This PR breaks the Athena build label Jul 10, 2024
kodiakhq bot pushed a commit that referenced this pull request Jul 30, 2024
…les (#3195)

After changes in the Core `CKF` we are now able to use the extrapolated parameters from within the CKF and don't need to redo the work.

Pulled out of #3188 to capture the reference change and the performance

blocked by
- #3161
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaks Athena build This PR breaks the Athena build Changes Performance Component - Core Affects the Core module Component - Examples Affects the Examples module Event Data Model Infrastructure Changes to build tools, continous integration, ... Track Finding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants