Format and update #732
Merged
Format and update #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, this file had a mix of 2 and 4 space indentation.
also follow the Recommended Node TSConfig settings for NodeJS v16 https://github.com/microsoft/TypeScript/wiki/Node-Target-Mapping#node-16
… installation phase
Updates eslint dependency to get rid of the peer dependency warning in the stable node release.
This commit makes sure that no '@jest/globals' types missing error is thrown when working in vscode.
This commit adds the `tsc:watch` script that can be used to compile the typescript code in watch mode.
This commit makes sure that the right syntax is used in the Prettier scripts.
Signed-off-by: jongwooo <[email protected]>
The javascript action does this: https://github.com/actions/javascript-action/blob/main/action.yml
appends src/
ensures every build difference is in the diff
This was referenced Aug 24, 2023
This was referenced Aug 24, 2023
This was referenced Aug 24, 2023
vmjoseph
reviewed
Aug 24, 2023
vmjoseph
approved these changes
Aug 24, 2023
dghubble
added a commit
to poseidon/wait-for-status-checks
that referenced
this pull request
Oct 28, 2024
* eslint seems to require another file format now ugh https://eslint.org/docs/latest/use/configure/migration-guide * Some of these plugins seem to have conflicting peer dependencies or no longer be in favor for some reason. At this point, GitHub's template for a Typescript action looks quite different and there is no good way to replicate these constant refactors into every action so I guess we're a bit on our own * Honestly this is frustrating. These tools are constantly changing, dependabot version bumps are rarely green, and these updates rarely add value. Consider if these tools are worth the time sink Rel: actions/typescript-action#732 Rel: actions/typescript-action#940
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a number of formatting, clarification, and other updates. It is an initial step in bringing the action template up to date. Specific updates below:
JavaScript:
nccoutputs and references todist/andlib/directories (they were mixed before, but now packaging and testing all point todist/).node-versionto specify local version for development/testingpackage.jsonpackage.jsonLinting/Validation:
.github/linters(so super-linter will pick it up automatically)GitHub Actions:
nameandidvalues across all action steps for easier comprehensionMisc:
READMEwith more descriptive setup/usage stepsCloses #727
Closes #718
Closes #717
Closes #711
Closes #704
Closes #652
Closes #650
Closes #646
Closes #645
Closes #630
Closes #629
Closes #626
Closes #623
Closes #616
Closes #595
Closes #562
Closes #560
Closes #559
Closes #528
Closes #497
Closes #489
Closes #474
Closes #473
Closes #463
Closes #418
Closes #306
Closes #283
Closes #243
Closes #187