Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix workflow - check dist/ #625

Closed
wants to merge 1 commit into from

Conversation

Justin-JHG
Copy link

@Justin-JHG Justin-JHG commented Dec 6, 2022

why this pull request?

currently the check dist/ workflow could fail if changes made on windows and action run on linux when checking diff on index.js.map, this is due to :

  • the tsc build could produce CRLF on windows and workflow run on linux is expectin LF as new line.
  • the package could be using cached option so the file is much smaller compare to the workflow artifect.

Changes have been made to add newLine option on tsc build and add no-cache option on package

@Justin-JHG Justin-JHG requested a review from a team as a code owner December 6, 2022 06:28
@Justin-JHG Justin-JHG changed the title Update package.json fix workflow - check dist/ Dec 6, 2022
@Justin-JHG
Copy link
Author

FYI - @rentziass , thanks

@SayakMukhopadhyay
Copy link
Contributor

SayakMukhopadhyay commented Jun 16, 2023

Just to keep track, PR #494 also does the TS fix but using config files. Hopefully this or 494 gets merged soon.

@ncalteen ncalteen self-assigned this Aug 24, 2023
@ncalteen
Copy link
Collaborator

Hello! Apologies for the delay on responding to this PR. As @SayakMukhopadhyay has mentioned, this should be fixed by #494 and updated in main once #732 is merged :)

@ncalteen ncalteen closed this Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants