add bin to path #47
Merged
add bin to path #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericsciple
reviewed
Mar 26, 2020
|
|
||
| let buf = cp.execSync('go env GOPATH'); | ||
| if (buf) { | ||
| let gp = buf.toString().trim(); |
There was a problem hiding this comment.
any concern about the output? for example should we check empty string
ericsciple
approved these changes
Mar 26, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix issue with cache dir (had spec instead of just version)
add bin to path
fix audit issues
update tool-cache lib
Details:
This bin dir is an output dir when you build + install something in go. So users want to call go build, go install and then run what they built. This adds that output dir to the path.
hosted images and some folks install go but if they never did a build + install on a clean machine (hosted) it won’t exist. That’s why I create it if (1) go is installed and (2) it doesn’t exist
To avoid fragility I exec go env GOPATH and let it tell me where it should be
Crux of the change: https://github.com/actions/setup-go/pull/47/files#diff-8cfead41d88ad47d44509a8ab0a109ad