Add $GOBIN #41
Closed
Add $GOBIN #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Set $GOBIN to $(go env GOPATH)/bin - Add $GOBIN to the PATH Should make the setup of tools like golangci-lint or golint work with a simple `go get`. Using $GOBIN instead of $GOPATH/bin because the goal is to have GOPATH not being directly referenced. Also, in the future, GOBIN will have a default value too, so we would not need to manually set it, just add it to the path (see discussion in golang/go#23439). Closes #14.
fsouza
added a commit
to fsouza/vod-module-sprite
that referenced
this pull request
Mar 2, 2020
1.14.0 satisfies ^1.13.6, so the test started failing once Go 1.14 was released. This test is going to break again when Go 1.15 is released, so maybe we need a better fix?
|
To see how this can be used: https://github.com/fsouza/vod-module-sprite/pull/15/files (Also notice the previous workaround in the "setup GOBIN" step). Commit 25c870b caused the tests to fail because what seemed to be an incorrect/fragile test. "1.14.0" satisfies "^1.13.6" (and it looks like semver doesn't support the ~ operator yet, which is likely what the test is designed to test?) I adjusted the test to make it green (using ^1.14.0 instead of ^1.13.6), but if we keep that test as is, it's going to fail every time there's a new "minor" release of Go. |
Should fix the behavior on Windows.
7 tasks
On Windows, `go env GOPATH` keeps the end-line character, making it unusable (see sample build failure: https://github.com/fsouza/vod-module-sprite/runs/478762225?check_suite_focus=true#step:5:62).
|
@bryanmacfarlane friendly ping? 😁 |
fsouza
added a commit
to fsouza/vod-module-sprite
that referenced
this pull request
Mar 9, 2020
|
I'm waiting for this feature :) |
|
Implemented in #47. |
Closed
|
Thank you @fsouza for raising the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should make the setup of tools like golangci-lint or golint work with a
simple
go get.Using $GOBIN instead of $GOPATH/bin because the goal is to have GOPATH
not being directly referenced. Also, in the future, GOBIN will have a
default value too, so we would not need to manually set it, just add it
to the path (see discussion in golang/go#23439).
Closes #14.