Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(AlephZero): Add manual withdrawal script and automate finalizations #1909

Merged
merged 15 commits into from
Nov 21, 2024

Conversation

nicholaspai
Copy link
Member

Similar to #1866 for OpStack but for Arbitrum Orbit.

Replaces original PR #1898 with smaller commit history. I essentially took the core changes and copied and pasted here, to avoid rebase hell

Similar to #1866 for OpStack but for Arbitrum Orbit.

Replaces original PR #1898 with smaller commit history. I essentially took the core changes and copied and pasted here, to avoid rebase hell
@nicholaspai nicholaspai marked this pull request as ready for review November 14, 2024 18:21
Copy link
Contributor

@james-a-morris james-a-morris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we not have this previously for arb?

@nicholaspai
Copy link
Member Author

Did we not have this previously for arb?

We did not. Arbitrum orbit has never had a lite chain in Across, yet, so we've never had to manually withdraw from Arbitrum

Copy link
Contributor

@james-a-morris james-a-morris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly nits + potential prods into how we'd like to use the script. Otherwise LGTM

scripts/withdrawFromArbitrumOrbit.ts Show resolved Hide resolved
scripts/withdrawFromArbitrumOrbit.ts Show resolved Hide resolved
scripts/withdrawFromArbitrumOrbit.ts Show resolved Hide resolved
@nicholaspai nicholaspai merged commit e4f5e39 into master Nov 21, 2024
4 checks passed
@nicholaspai nicholaspai deleted the npai/aleph-zero-manual-withdraw branch November 21, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants