-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Automate withdrawing ETH from OpStack chains #1866
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds a new script to withdraw ETH via the OVM standard L2 bridge to the signer's address on L1 - Adds a feature to the OP stack finalizer that lets the user specify addresses that they want to finalize OVM withdrawals for, in addition to any existing SpokePool withdrawals. This pairs with the above script to allow us to one-step manually move ETH from OP stack chains back to the same EOA on Ethereum - To use this new feature, we need to add new chains to the finalizer config (i.e. 7777777 and 1135) and also set `WITHDRAWAL_TO_ADDRESSES=[x]` where `x` are addresses that we plan to execute manual withdrawals from
nicholaspai
requested review from
mrice32,
pxrl and
james-a-morris
as code owners
October 16, 2024 19:03
pxrl
reviewed
Oct 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will definitely be useful.
Co-authored-by: Paul <[email protected]>
pxrl
approved these changes
Oct 22, 2024
nicholaspai
added a commit
that referenced
this pull request
Nov 6, 2024
Similar to #1866 but for AlephZero which is an Arbitrum Orbit chain
nicholaspai
added a commit
that referenced
this pull request
Nov 7, 2024
Similar to #1866 but for AlephZero which is an Arbitrum Orbit chain
nicholaspai
added a commit
that referenced
this pull request
Nov 21, 2024
…ons (#1909) * feat(AlephZero): Add manual withdrawal script and automate finalizations Similar to #1866 for OpStack but for Arbitrum Orbit. Replaces original PR #1898 with smaller commit history. I essentially took the core changes and copied and pasted here, to avoid rebase hell * WIP * WIP * wip * Update ContractAddresses.ts * Update arbStack.ts * Update arbStack.ts * Update arbStack.ts * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WITHDRAWAL_TO_ADDRESSES=[x]
wherex
are addresses that we plan to execute manual withdrawals from