Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Automate withdrawing ETH from OpStack chains #1866

Merged
merged 10 commits into from
Oct 22, 2024

Conversation

nicholaspai
Copy link
Member

  • Adds a new script to withdraw ETH via the OVM standard L2 bridge to the signer's address on L1
  • Adds a feature to the OP stack finalizer that lets the user specify addresses that they want to finalize OVM withdrawals for, in addition to any existing SpokePool withdrawals. This pairs with the above script to allow us to one-step manually move ETH from OP stack chains back to the same EOA on Ethereum
  • To use this new feature, we need to add new chains to the finalizer config (i.e. 7777777 and 1135) and also set WITHDRAWAL_TO_ADDRESSES=[x] where x are addresses that we plan to execute manual withdrawals from

- Adds a new script to withdraw ETH via the OVM standard L2 bridge to the signer's address on L1
- Adds a feature to the OP stack finalizer that lets the user specify addresses that they want to finalize OVM withdrawals for, in addition to any existing SpokePool withdrawals. This pairs with the above script to allow us to one-step manually move ETH from OP stack chains back to the same EOA on Ethereum
- To use this new feature, we need to add new chains to the finalizer config (i.e. 7777777 and 1135) and also set `WITHDRAWAL_TO_ADDRESSES=[x]` where `x` are addresses that we plan to execute manual withdrawals from
Copy link
Contributor

@pxrl pxrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will definitely be useful.

src/common/Constants.ts Outdated Show resolved Hide resolved
scripts/withdrawFromOpStack.ts Outdated Show resolved Hide resolved
scripts/withdrawFromOpStack.ts Show resolved Hide resolved
src/finalizer/utils/opStack.ts Show resolved Hide resolved
@nicholaspai nicholaspai requested a review from pxrl October 18, 2024 14:04
@nicholaspai nicholaspai merged commit 119ca6b into master Oct 22, 2024
4 checks passed
@nicholaspai nicholaspai deleted the npai/opstack-withdrawal branch October 22, 2024 12:45
@nicholaspai nicholaspai restored the npai/opstack-withdrawal branch October 23, 2024 13:49
nicholaspai added a commit that referenced this pull request Nov 6, 2024
Similar to #1866 but for AlephZero which is an Arbitrum Orbit chain
nicholaspai added a commit that referenced this pull request Nov 7, 2024
Similar to #1866 but for AlephZero which is an Arbitrum Orbit chain
nicholaspai added a commit that referenced this pull request Nov 14, 2024
Similar to #1866 for OpStack but for Arbitrum Orbit.

Replaces original PR #1898 with smaller commit history. I essentially took the core changes and copied and pasted here, to avoid rebase hell
nicholaspai added a commit that referenced this pull request Nov 21, 2024
…ons (#1909)

* feat(AlephZero): Add manual withdrawal script and automate finalizations

Similar to #1866 for OpStack but for Arbitrum Orbit.

Replaces original PR #1898 with smaller commit history. I essentially took the core changes and copied and pasted here, to avoid rebase hell

* WIP

* WIP

* wip

* Update ContractAddresses.ts

* Update arbStack.ts

* Update arbStack.ts

* Update arbStack.ts

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants