improve(bridges): add special USDC case for the ScrollBridge. #1720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bennett <[email protected]>
bmzig
requested review from
mrice32,
nicholaspai,
pxrl and
james-a-morris
as code owners
Essentially. It's a fix for the todo brought up in this PR #1708 |
james-a-morris
approved these changes
Aug 5, 2024
ishantiw
pushed a commit
to LiskHQ/across-relayer
that referenced
this pull request
Aug 8, 2024
…-protocol#1720) Signed-off-by: bennett <[email protected]>
ishantiw
pushed a commit
to LiskHQ/across-relayer
that referenced
this pull request
Aug 8, 2024
…-protocol#1720) Signed-off-by: bennett <[email protected]>
sameersubudhi
pushed a commit
to LiskHQ/across-relayer
that referenced
this pull request
Sep 10, 2024
…-protocol#1720) Signed-off-by: bennett <[email protected]>
sameersubudhi
pushed a commit
to LiskHQ/across-relayer
that referenced
this pull request
Sep 10, 2024
…-protocol#1720) Signed-off-by: bennett <[email protected]>
sameersubudhi
pushed a commit
to LiskHQ/across-relayer
that referenced
this pull request
Sep 10, 2024
…-protocol#1720) Signed-off-by: bennett <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple fix to the issue we had for resolving a USDC address for scroll, whereby we would include a special case in
resolveL2TokenAddressin BaseBridgeAdapter. This moves this logic to the Scroll bridge so this conditional won't be triggered by all bridges.