fix(generic bridges): use scroll's canonical bridge function

[bmzig]

This fixes an improperly set method on Arbitrum (not sending any msg.value to the outboundTransfer function), as well as removes ScrollWethBridge in favor of the ScrollERC20Bridge. The latter is done since we can simply bridge WETH to Scroll via the gateway router, which can subsequently be wrapped/unwrapped, so a dedicated bridge to interface with an atomic depositor is not needed.

---

As an overview. We recently merged in the generic adapters PR #1524, which at the time of writing, is dormant in production, since the generic AdapterManager in src/adapter/ is only activated if we set RELAYER_USE_GENERIC_ADAPTER and/or MONITOR_USE_GENERIC_ADAPTER in the environment. Now that it is merged, instead of making an entirely new ScrollAdapter, we can make a wrapper for the generic BaseChainAdapter and begin integrating the new code into our current structure. Going forward, we should continue to replace the existing specialized adapters (e.g. ArbitrumAdapter, LineaAdapter, ZkSyncAdapter, etc.) with wrappers for BaseChainAdapter using the same format found here

relayer/src/adapter/AdapterManager.ts

Line 35 in 5bd2efd

Object.values(this.spokePoolClients)

. Once all the adapters are replaced with their generic counterparts, we should be able to remove everything in src/clients/bridges/ except for CrossChainTransferClient, which will remain unchanged.

[nicholaspai]

(although this shouldn't be preferred since we would receive WETH, not ETH, on Scroll).

I'm confused by this. We should be happy to send WETH, because the bots should know how to unwrap WETH into ETH, right? This function should be run here before evaluating any WETH rebalances, allowing the bots to always assume it has enough ETH in its balance before evaluating WETH inventory sends.

From the inventory manager's perspective, ETH is treated as gas balance and WETH is an inventory balance

[nicholaspai]

Couple questions, but nice to remove the Scroll(Atomic)WethBridge!

[bmzig]

ERC20 transfer tracking is working now.

[pxrl]

I've tested this OK when rebalancing all 4 supported tokens. Cross-chain transfer tracking worked correctly. There are some items here that could be revisited for a post-merge cleanup, but for now this is OK to go in.