Lupl/ordering feature #227
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lu-pl
force-pushed
the
lupl/ordering-feature
branch
2 times, most recently
from
bf6a3e0 to
7a61bcb
Compare
The specific type annotation 'type[_TModelInstance]' in model_utils.model_traverse is not correct for recursive code paths; the broader annotation 'type[BaseModel]' is more more appropriate.
lu-pl
force-pushed
the
lupl/ordering-feature
branch
3 times, most recently
from
ce33622 to
242059c
Compare
sparql_utils.add_solution_modifier previously added the SPARQL variable marker "?"; this however does not allow to pass ASC/DESC modifiers. The change generalizes the add_solution_modifier templating and requires SPARQL variables to be passed with a variable marker. Also, the respective unit tests are adapted.
lu-pl
force-pushed
the
lupl/ordering-feature
branch
from
242059c to
4bc0606
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #171 .