feat: add beartype checking #153
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beartype offers high performance runtime type checking based on type annotations. Runtime checking can contribute to a healthier code base (see fixes) and also allows fast failures with meaningful exceptions for library users. Closes #152.
beartype revealed several incorrect typed annotations which lead to failing tests.
Runtime checking mock objects is an interesting case! Mock objects rightfully get rejected by runtime type checking, the solution is to point the mock object's __class__ to the class of the mocked object. See beartype/beartype#92.
Package-wide beartype runtime checking requires 'beartype_this_package' to run *before* all other __init__ imports. This is not PEP-8 compliant, see https://peps.python.org/pep-0008/#imports.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #152