Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of toolz #55

Closed
b1rger opened this issue Aug 14, 2024 · 0 comments
Closed

Get rid of toolz #55

b1rger opened this issue Aug 14, 2024 · 0 comments
Assignees
Labels
dependencies Pull requests that update a dependency file refactor Implementation changes that preserve external interfaces and the behavior of the software.

Comments

@b1rger
Copy link
Collaborator

b1rger commented Aug 14, 2024

toolz is only used once in the codebase. I'm sure we find numerous ways to replace valmap with standard Python.

lu-pl added a commit that referenced this issue Aug 17, 2024
Replace toolz.valmap in get_bindings_from_query_result with dict
comprehension and remove unnecessary type cast.

Since toolz.valmap was the only use of toolz in the codebase, the
toolz dependency can be removed.

Closes: #55
@lu-pl lu-pl self-assigned this Aug 17, 2024
@lu-pl lu-pl added dependencies Pull requests that update a dependency file refactor Implementation changes that preserve external interfaces and the behavior of the software. labels Aug 17, 2024
lu-pl added a commit that referenced this issue Aug 17, 2024
Replace toolz.valmap in get_bindings_from_query_result with dict
comprehension and remove unnecessary type cast.

Since toolz.valmap was the only use of toolz in the codebase, the
toolz dependency can be removed.

Closes: #55
@lu-pl lu-pl closed this as completed Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file refactor Implementation changes that preserve external interfaces and the behavior of the software.
Projects
None yet
Development

No branches or pull requests

2 participants