Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix _TModelConstructorCallable type and revise type definitions #10

Closed
lu-pl opened this issue Jul 25, 2024 · 0 comments · Fixed by #15 or #16
Closed

Fix _TModelConstructorCallable type and revise type definitions #10

lu-pl opened this issue Jul 25, 2024 · 0 comments · Fixed by #15 or #16
Assignees
@lu-pl

Comments

@lu-pl
Copy link
Contributor

lu-pl commented Jul 25, 2024

_TModelConstructorCallable type definition is incorrect, also generally revise type definitions. E.g _TModelInstance is still defined in generic classes/functions.
@lu-pl lu-pl self-assigned this Jul 25, 2024
lu-pl added a commit that referenced this issue Jul 25, 2024
@lu-pl
fix: Type hint cleanup
f33cb8d 
closes: #10
@lu-pl lu-pl mentioned this issue Jul 25, 2024
Merged
lu-pl added a commit that referenced this issue Jul 25, 2024
@lu-pl
fix: Type hint cleanup
b73fc95 
Replaced ModelInstance type with
rdfproxy.utils._types._TMOdelInstance. ModelInstance was defined using
PEP 695 before but the type will be used all over the code base and
should have a central definition.

Fixed _TModelConstructorCallable type to be a Callable expecting a
SPARQLWrapper.QueryResult parameter and returning an Iterable of
Pydantic model instances.

closes: #10
@lu-pl lu-pl closed this as completed in f4c0448 Jul 26, 2024
@lu-pl lu-pl closed this as completed in #15 Jul 26, 2024
@github-actions github-actions bot mentioned this issue Jul 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lu-pl lu-pl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Type hint cleanup acdh-oeaw/rdfproxy
chore(main): release 0.1.0 acdh-oeaw/rdfproxy
1 participant
@lu-pl