Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui-markdown-editor): Implemented Code Block #380

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

d-e-v-esh
Copy link
Contributor

Signed-off-by: Devesh [email protected]

Closes #30

This PR builds on top of #289 and solves some of the problems that it had
i.e. enter key problem, text crossing the border of the code block

Changes

  • Added a new button.
  • Added proper styling to the blocks

Flags

  • The icon in the current condition does not match with other icons in the toolbar.

Screenshots or Video

brave_RFFsqHHo11

Related Issues

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to master from fork:branchname
  • Manual accessibility test performed
    • Keyboard-only access, including forms
    • Contrast at least WCAG Level A
    • Appropriate labels, alt text, and instructions

@dselman dselman self-requested a review February 22, 2022 15:46
Copy link
Contributor

@dselman dselman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can apply styling inside the code block (e.g. bold/italic). If you apply list formatting the editor crashes.

@d-e-v-esh
Copy link
Contributor Author

d-e-v-esh commented Feb 22, 2022

@dselman It is only crashing on the deploy preview for some reason, it does not crash in the local build.

brave_wWTSWmqZSx

What could be the reason for this? Does the crash error give any hints?
Should the list item work like normal inside the code block or should we prevent it when the cursor is in the code block?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Markdown support: Code blocks
2 participants