Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Markdown support: Code blocks #30

Open
jeromesimeon opened this issue Nov 12, 2019 · 5 comments · May be fixed by #380
Open

Markdown support: Code blocks #30

jeromesimeon opened this issue Nov 12, 2019 · 5 comments · May be fixed by #380
Labels
Difficulty: Medium Package: Markdown Editor ⌨️ Type: Feature Request 🛍️ New feature or request

Comments

@jeromesimeon
Copy link
Member

Is your feature request related to a problem? Please describe.
Code blocks are a useful markdown feature. It would be nice if the editor supports them.

Describe the solution you'd like
The ability to create/edit/delete code blocks.

Maybe the ability to turn into a selection into a code block would be nice as well/
@jolanglinais jolanglinais transferred this issue from accordproject/markdown-editor May 13, 2020
@K-Kumar-01
Copy link
Contributor

K-Kumar-01 commented Mar 6, 2021 •
edited
Loading

@jeromesimeon @irmerk
Did some work to add the feature.
Here is a recording.
https://www.loom.com/share/238dbd1abb1e4a159038d113c61860aa

Is this feature correct?
Let me know if there are any changes required.

some things to note:

  1. the icon used is similar to the code icon
  2. Shortcut key does not work currently

@K-Kumar-01
Copy link
Contributor

@jeromesimeon @irmerk
Requesting your review

@jolanglinais
Copy link
Member

Should this support start in markdown-transform @jeromesimeon?

@jeromesimeon
Copy link
Member Author

Should this support start in markdown-transform @jeromesimeon?

We already support code blocks in the markdown-transform

The video looks nice. Sadly the bottom of the screen doesn't show the markdown for that part of the document (I don't think?) so it's difficult to say if what's in the editor gets properly translated to a markdown block.

@K-Kumar-01 This looks great. If you have another video, or maybe even better a PR we could evaluate your proposal better!

@K-Kumar-01 K-Kumar-01 mentioned this issue Mar 11, 2021
Closed
9 tasks
K-Kumar-01 added a commit to K-Kumar-01/web-components that referenced this issue Mar 18, 2021
@K-Kumar-01
feat(ui-markdown-editor): Code Block Support - accordproject#30
59f038e 
Changed Code Block Icon
Added hotkey implementation

Signed-off-by: k-kumar-01 <[email protected]>
@jolanglinais
Copy link
Member

Use #289 as reference when starting this.

@d-e-v-esh d-e-v-esh linked a pull request Feb 22, 2022 that will close this issue
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Difficulty: Medium Package: Markdown Editor ⌨️ Type: Feature Request 🛍️ New feature or request
Projects
None yet
Milestone
No milestone
3 participants
@jeromesimeon @jolanglinais @K-Kumar-01