Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(concerto) Add version 0.3 of Concerto metamodel #146

Merged
merged 2 commits into from
Sep 27, 2021
Merged

feature(concerto) Add version 0.3 of Concerto metamodel #146

merged 2 commits into from
Sep 27, 2021

Conversation

jeromesimeon
Copy link
Member

Signed-off-by: jeromesimeon [email protected]

Description

This PR includes a new version 0.3 for the Concerto MetaModel, with improvements to the structure and terminology.

Changes

  • Rename field to property throughout the metamodel
  • Remove the abstract ClassDeclaration, using ConceptDeclaration as the top-most type for concept/asset/transaction/even/participants
  • Some corresponding cleanups to default values
  • Some corresponding cleanups to the top level properties, using enums and concepts for clarity in the instances

Flags

  • This is a non-backward compatible change
  • This should be tested in Concerto itself and in the Model Builder in Web components

@jeromesimeon
Copy link
Member Author

@stefanblaginov Feedback welcome!

mttrbrts
mttrbrts approved these changes Sep 27, 2021
View reviewed changes
Copy link
Member

@mttrbrts mttrbrts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly independent comments on the @FormEditor decorators. I need to find a way to customise those in client code

src/concerto/[email protected] Show resolved Hide resolved
src/concerto/[email protected] Outdated Show resolved Hide resolved
src/concerto/[email protected] Outdated Show resolved Hide resolved
src/concerto/[email protected] Outdated Show resolved Hide resolved
@jeromesimeon jeromesimeon mentioned this pull request Sep 27, 2021
Merged
@jeromesimeon jeromesimeon merged commit 411f462 into accordproject:master Sep 27, 2021
@jeromesimeon jeromesimeon deleted the js-metamode-0.3 branch September 29, 2021 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mttrbrts mttrbrts mttrbrts approved these changes

@dselman dselman Awaiting requested review from dselman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeromesimeon @mttrbrts