-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(metamodel) Switches to Concerto metamodel 0.3 #338
fix(metamodel) Switches to Concerto metamodel 0.3 #338
Conversation
@stefanblaginov Feedback welcome. Those are changes to the metamodel API for Concerto based on accordproject/models#146 |
0d1b75c
to
1e8ed3e
Compare
Signed-off-by: jeromesimeon <[email protected]>
1e8ed3e
to
b4a3ad8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We will still have the round-trip ordering issue with enums / concepts to/from CTO - but perhaps we live with that for now?
Yeah, there are a few things that we could consider depending on our release timing:
|
b107b8e
to
93f510e
Compare
@mttrbrts @dselman Made the changes we discussed today. A follow up review would be appreciated. New metamodel is available here: accordproject/models#147 |
Signed-off-by: jeromesimeon <[email protected]>
93f510e
to
798815d
Compare
Signed-off-by: jeromesimeon <[email protected]>
Signed-off-by: jeromesimeon [email protected]
Description
Switches metamodel support to Concerto Metamodel
0.3
which includes terminology and some structural changes (no more abstractClassDeclaration
.Changes
field
renamed toproperty
class
usingconcept
insteadenums
andconcepts
Flags
2.0
seems somewhat overkill though. Keeping a backward compatible version would be quite a lot of work. Anyone has suggestions?