Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(metamodel) Switches to Concerto metamodel 0.3 #338

Merged
merged 3 commits into from
Oct 4, 2021

Conversation

jeromesimeon
Copy link
Member

@jeromesimeon jeromesimeon commented Sep 27, 2021

Signed-off-by: jeromesimeon [email protected]

Description

Switches metamodel support to Concerto Metamodel 0.3 which includes terminology and some structural changes (no more abstract ClassDeclaration.

Changes

  • field renamed to property
  • no longer use class using concept instead
  • toplevel declarations are now enums and concepts

Flags

@jeromesimeon
Copy link
Member Author

@stefanblaginov Feedback welcome. Those are changes to the metamodel API for Concerto based on accordproject/models#146

@jeromesimeon jeromesimeon force-pushed the js-metamodel-0.3 branch 2 times, most recently from 0d1b75c to 1e8ed3e Compare September 27, 2021 14:15
Copy link
Contributor

@dselman dselman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We will still have the round-trip ordering issue with enums / concepts to/from CTO - but perhaps we live with that for now?

@jeromesimeon
Copy link
Member Author

jeromesimeon commented Sep 29, 2021

LGTM. We will still have the round-trip ordering issue with enums / concepts to/from CTO - but perhaps we live with that for now?

Yeah, there are a few things that we could consider depending on our release timing:

  • revert the enums / concepts declaration separation (it does round trip but loses the order atm). it's been done this way mostly for UI because in the UI it is more readable to separate enums from concepts -- but conceptually it would be better to leave that as a task for the UI developer to figure out.
  • should fully qualified names just have a namespace instead? (a user would have to split the FQN to get the namespace atm)
  • version? I think this one is likely out of reach

@jeromesimeon
Copy link
Member Author

@mttrbrts @dselman Made the changes we discussed today. A follow up review would be appreciated. New metamodel is available here: accordproject/models#147

@jeromesimeon jeromesimeon merged commit 49b0ceb into accordproject:master Oct 4, 2021
@jeromesimeon jeromesimeon deleted the js-metamodel-0.3 branch October 4, 2021 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants