Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): new pathway to apply namespace targeted decorators #877

Conversation

sanketshevkar
Copy link
Member

@sanketshevkar sanketshevkar commented Jul 10, 2024

Closes #874

Changes

  • Introduce new feature flag accessed using optional parameters and as environment variable to enable new pathway
  • When flags disabled, namespace targeted dcs would be get applied to all declarations within a namespace and if enabled just on top of the namespace.
  • A new warning emitter pattern introduced to emit deprecation warning.

Flags

Screenshots or Video

Related Issues

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

packages/concerto-core/index.js Outdated Show resolved Hide resolved
packages/concerto-core/lib/decoratormanager.js Outdated Show resolved Hide resolved
packages/concerto-core/lib/decoratormanager.js Outdated Show resolved Hide resolved
packages/concerto-util/lib/warning.js Outdated Show resolved Hide resolved
packages/concerto-util/lib/warning.js Show resolved Hide resolved
packages/concerto-core/api.txt Outdated Show resolved Hide resolved
packages/concerto-core/api.txt Outdated Show resolved Hide resolved
packages/concerto-core/api.txt Outdated Show resolved Hide resolved
packages/concerto-core/lib/introspect/modelfile.js Outdated Show resolved Hide resolved
@sanketshevkar sanketshevkar requested a review from mttrbrts July 10, 2024 09:50
Copy link
Contributor

@dselman dselman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concerto-Core needs to be usable within the web browser.

packages/concerto-util/lib/warning.js Outdated Show resolved Hide resolved
@sanketshevkar sanketshevkar requested a review from dselman July 10, 2024 15:31
@sanketshevkar sanketshevkar merged commit 08eeee5 into accordproject:main Jul 11, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DCS with namespace target, don't apply decorators on top of the namespace.
3 participants