-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(common): check dependecy in decorators #126
Conversation
Signed-off-by: Muhammed Abdulkadir <[email protected]>
Signed-off-by: muhammed-abdulkadir <[email protected]>
Signed-off-by: muhammed-abdulkadir <[email protected]>
const fqn = modelFile.getFullyQualifiedTypeName(argument.name); | ||
if (fqn) { | ||
parameters.graph.addVertex(fqn); | ||
(parent === modelFile) ? parameters.graph.addEdge(parent.getNamespace(), fqn) : parameters.graph.addEdge(parent.getFullyQualifiedName(), fqn); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(parent === modelFile) ? parameters.graph.addEdge(parent.getNamespace(), fqn)
This allows for a model decorated with a type reference to act as a vertex in a connected graph, causing it to be included when users search for subgraphs.
This behavior arises because we currently allow models to be decorated with type references, which implicitly suggests a composition. However, since we treat models as packages, we should avoid compositions on the packages themselves.
Closes #<125>
Changes
Screenshots or Video
Author Checklist
--signoff
option of git commit.main
fromfork:branchname