Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vocabulary) : support multiple terms per concept/property #664

Merged
merged 7 commits into from
Jul 23, 2023

Conversation

dselman
Copy link
Contributor

@dselman dselman commented Jul 5, 2023

Closes #645

Changes

Flags

Screenshots or Video

Related Issues

  • Issue #
  • Pull Request #

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

@sanketshevkar
Copy link
Member

sanketshevkar commented Jul 10, 2023

Hi @dselman
Here is the PR fixing the bug and I've new test cases.
#666

@dselman dselman marked this pull request as ready for review July 12, 2023 14:39
@dselman dselman requested a review from a team July 12, 2023 14:39
@sanketshevkar
Copy link
Member

@dselman I had to fix tests for the changes made, here is PR for that #667
I had signed off the previous commits, but not sure why DCO check is failing.

@dselman
Copy link
Contributor Author

dselman commented Jul 12, 2023

@dselman I had to fix tests for the changes made, here is PR for that #667
I had signed off the previous commits, but not sure why DCO check is failing.

image

@dselman
Copy link
Contributor Author

dselman commented Jul 12, 2023

@sanketshevkar can you please resolve the merge conflicts, check all tests pass and fix DCO?

dselman and others added 3 commits July 12, 2023 23:58
…es (#666)

* feat(vocabulary): resolved bug for properties and added more test cases

Signed-off-by: sanketshevkar <[email protected]>

* feat(vocabulary): fix to support vocab attributes without '.'

Signed-off-by: sanketshevkar <[email protected]>

---------

Signed-off-by: sanketshevkar <[email protected]>
* feat(vocabulary): resolved bug for properties and added more test cases

Signed-off-by: sanketshevkar <[email protected]>

* feat(vocabulary): fix to support vocab attributes without '.'

Signed-off-by: sanketshevkar <[email protected]>

* feat(vocabulary): old breaking test fixed

Signed-off-by: sanketshevkar <[email protected]>

---------

Signed-off-by: sanketshevkar <[email protected]>
@sanketshevkar
Copy link
Member

@sanketshevkar can you please resolve the merge conflicts, check all tests pass and fix DCO?

Done! I directly committed to this branch, the merge conflict fix and previous DCO signoffs. It is expecting the signoff from some GitHub-generated id, but I had done it using my personal id.
Making changes directly to this branch worked.
I hope this is fine, if not I can revert back.
Thank you

Signed-off-by: Matt Roberts <[email protected]>
@mttrbrts mttrbrts enabled auto-merge (squash) July 23, 2023 18:44
@mttrbrts mttrbrts merged commit ac70543 into main Jul 23, 2023
@mttrbrts mttrbrts deleted the ds-multiple-terms branch July 23, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow multiple vocabulary terms per concept and property
3 participants