Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core):added extract decorator method #754

Merged
merged 25 commits into from
Nov 14, 2023
Merged

feat(core):added extract decorator method #754

merged 25 commits into from
Nov 14, 2023

Conversation

muskanbararia
Copy link
Contributor

@muskanbararia muskanbararia commented Nov 6, 2023 •
edited
Loading

Closes #753

Extend DecoratorManager to support extraction of vocab and decorators from a modelManager.

Changes

  • Exposes a new extractDecorator method from decoratorManager.

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

Muskan Bararia added 4 commits November 6, 2023 13:22
mttrbrts
mttrbrts reviewed Nov 6, 2023
View reviewed changes
Copy link
Member

@mttrbrts mttrbrts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Muskan, in this pass I've mostly focussed on functional design and naming.

packages/concerto-core/lib/decoratormanager.js Show resolved Hide resolved
packages/concerto-core/lib/decoratormanager.js Outdated Show resolved Hide resolved
packages/concerto-core/lib/decoratormanager.js Outdated Show resolved Hide resolved
packages/concerto-core/lib/decoratormanager.js Outdated Show resolved Hide resolved
packages/concerto-core/test/decoratormanager.js Outdated Show resolved Hide resolved
packages/concerto-core/test/decoratormanager.js Show resolved Hide resolved
packages/concerto-core/lib/decoratormanager.js Outdated Show resolved Hide resolved
ekarademir
ekarademir reviewed Nov 7, 2023
View reviewed changes
packages/concerto-core/lib/decoratormanager.js Outdated Show resolved Hide resolved
packages/concerto-core/test/decoratormanager.js Outdated Show resolved Hide resolved
packages/concerto-core/lib/decoratormanager.js Outdated Show resolved Hide resolved
packages/concerto-core/lib/decoratormanager.js Show resolved Hide resolved
packages/concerto-core/lib/decoratormanager.js Outdated Show resolved Hide resolved
packages/concerto-core/lib/decoratormanager.js Outdated Show resolved Hide resolved
packages/concerto-core/lib/decoratormanager.js Outdated Show resolved Hide resolved
packages/concerto-core/lib/decoratormanager.js Outdated Show resolved Hide resolved
packages/concerto-core/lib/decoratormanager.js Outdated Show resolved Hide resolved
packages/concerto-core/lib/decoratormanager.js Outdated Show resolved Hide resolved
Muskan Bararia added 3 commits November 7, 2023 16:18
mttrbrts
mttrbrts reviewed Nov 7, 2023
View reviewed changes
packages/concerto-core/lib/decoratormanager.js Outdated Show resolved Hide resolved
packages/concerto-core/lib/decoratormanager.js Outdated Show resolved Hide resolved
packages/concerto-core/test/decoratormanager.js Outdated Show resolved Hide resolved
packages/concerto-core/test/decoratormanager.js Outdated Show resolved Hide resolved
packages/concerto-core/lib/decoratormanager.js Outdated Show resolved Hide resolved
jonathan-casey
jonathan-casey requested changes Nov 9, 2023
View reviewed changes
Copy link
Member

@jonathan-casey jonathan-casey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @muskanbararia can you please run a linter to fix the formatting niggles? Thanks!

fix:minor linting fixes
55a2547 
Signed-off-by: Muskan Bararia <[email protected]>
ekarademir
ekarademir reviewed Nov 10, 2023
View reviewed changes
packages/concerto-core/lib/decoratorutil.js Outdated Show resolved Hide resolved
packages/concerto-core/lib/decoratorutil.js Outdated Show resolved Hide resolved
packages/concerto-core/lib/decoratormanager.js Outdated Show resolved Hide resolved
packages/concerto-core/lib/decoratormanager.js Outdated Show resolved Hide resolved
packages/concerto-core/lib/decoratorutil.js Outdated Show resolved Hide resolved
packages/concerto-core/lib/decoratorutil.js Outdated Show resolved Hide resolved
Muskan Bararia added 2 commits November 10, 2023 19:22
ekarademir
ekarademir reviewed Nov 13, 2023
View reviewed changes
packages/concerto-core/lib/decoratorutil.js Outdated Show resolved Hide resolved
packages/concerto-core/lib/decoratorutil.js Outdated Show resolved Hide resolved
packages/concerto-core/lib/decoratorutil.js Outdated Show resolved Hide resolved
ekarademir
ekarademir reviewed Nov 13, 2023
View reviewed changes
packages/concerto-core/lib/decoratorutil.js Outdated Show resolved Hide resolved
packages/concerto-core/lib/decoratorutil.js Outdated Show resolved Hide resolved
packages/concerto-core/lib/decoratorutil.js Outdated Show resolved Hide resolved
packages/concerto-core/lib/decoratorutil.js Outdated Show resolved Hide resolved
packages/concerto-core/lib/decoratorutil.js Outdated Show resolved Hide resolved
packages/concerto-core/lib/decoratorutil.js Outdated Show resolved Hide resolved
Muskan Bararia added 2 commits November 14, 2023 11:52
chore: Merge branch 'main' of https://github.com/muskanbararia/concerto…
079f3a5 
… into muskanb/i753/extract_decorators_and_vocab

Signed-off-by: Muskan Bararia <[email protected]>
chore: added linting fix
d86d203 
Signed-off-by: Muskan Bararia <[email protected]>
@mttrbrts mttrbrts enabled auto-merge (squash) November 14, 2023 13:19
@mttrbrts mttrbrts merged commit b356260 into accordproject:main Nov 14, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-casey jonathan-casey jonathan-casey approved these changes

@mttrbrts mttrbrts mttrbrts approved these changes

@ekarademir ekarademir ekarademir approved these changes

@sanketshevkar sanketshevkar Awaiting requested review from sanketshevkar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Extract the vocabulary set and decorator command set from a model manager
5 participants
@muskanbararia @ekarademir @mttrbrts @sanketshevkar @jonathan-casey